KAFKA-8736: Streams performance improvement, use isEmpty() rather tha…#7164
Merged
mjsax merged 1 commit intoapache:trunkfrom Aug 6, 2019
Merged
KAFKA-8736: Streams performance improvement, use isEmpty() rather tha…#7164mjsax merged 1 commit intoapache:trunkfrom
mjsax merged 1 commit intoapache:trunkfrom
Conversation
Member
|
Thanks for the PR! LGTM. I think this should be cherry-picked back to 2.3 cc/ @bbejeck @mjsax @guozhangwang |
mjsax
approved these changes
Aug 5, 2019
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
LGTM.
Waiting for Jenkins to finish before we can merge.
guozhangwang
approved these changes
Aug 5, 2019
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
Thanks @mjarvie ! LGTM.
Member
|
Java 11 / 2.12 failed with Retest this please |
Member
|
Java 11 / 2.12: Merging. Thanks for the PR @mjarvie |
mjsax
pushed a commit
that referenced
this pull request
Aug 6, 2019
…n size() == 0 (#7164) Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <guozhang@confluent.io>
mjsax
pushed a commit
that referenced
this pull request
Aug 6, 2019
…n size() == 0 (#7164) Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <guozhang@confluent.io>
mjsax
pushed a commit
that referenced
this pull request
Aug 6, 2019
…n size() == 0 (#7164) Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <guozhang@confluent.io>
mjsax
pushed a commit
that referenced
this pull request
Aug 6, 2019
…n size() == 0 (#7164) Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <guozhang@confluent.io>
Member
|
Merged to |
3 tasks
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Aug 8, 2019
The avro upgrade was needed to fix the following error during ':support-metrics-client:generateAvro': Caused by: org.apache.velocity.exception.MethodInvocationException: Variable $velocityCount has not been set at /org/apache/avro/compiler/specific/templates/java/classic/record.vm[line 82, column 150] Conflicts: * gradle.properties -> trivial fix, `scalaVersion` is next to `version`, which is different in ccs kafka * gradle/dependencies.gradle -> reduce divergence with apache kafka by using `httpclient` instead of `httpcomponents` from the `versions` array. Remove unused `httpmime` and `httpcomponents` from said array. * apache-github/trunk: MINOR: Update dependencies for Kafka 2.4 (apache#7126) KAFKA-8599: Use automatic RPC generation in ExpireDelegationToken MINOR: Upgrade jackson-databind to 2.9.9.3 (apache#7125) MINOR: some small style fixes to RoundRobinPartitioner KAFKA-8736: Streams performance improvement, use isEmpty() rather than size() == 0 (apache#7164) Minor: Refactor methods to add metrics to sensor in `StreamsMetricsImpl` (apache#7161)
xiowu0
pushed a commit
to linkedin/kafka
that referenced
this pull request
Aug 22, 2019
…t, use isEmpty() rather than size() == 0 (apache#7164) TICKET = KAFKA-8736 LI_DESCRIPTION = EXIT_CRITERIA = HASH [0826d6e] ORIGINAL_DESCRIPTION = Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <guozhang@confluent.io> (cherry picked from commit 0826d6e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n size() == 0
According to https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentSkipListMap.html#size--, the size method has to traverse all elements to get a count. It looks like the count is being compared against 0 to determine if the map is empty; In this case, we don't need a full count. Instead, the isEmpty() method should be used, which just looks for one node.
No expected changes to unit or integration tests.
Committer Checklist (excluded from commit message)