Skip to content

MINOR: Remove activeTaskCheckpointableOffsets from AbstractTask#7253

Merged
guozhangwang merged 1 commit intoapache:trunkfrom
cadonna:make_activeTaskCheckpointableOffsets_private
Aug 29, 2019
Merged

MINOR: Remove activeTaskCheckpointableOffsets from AbstractTask#7253
guozhangwang merged 1 commit intoapache:trunkfrom
cadonna:make_activeTaskCheckpointableOffsets_private

Conversation

@cadonna
Copy link
Copy Markdown
Member

@cadonna cadonna commented Aug 26, 2019

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 26, 2019

@cpettitt-confluent
Copy link
Copy Markdown
Contributor

Verified this is only used in StreamTask. All for moving Stream/Standby specific stuff out of AbstractTask! LGTM.

Copy link
Copy Markdown
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Copy link
Copy Markdown
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase?

@cadonna cadonna force-pushed the make_activeTaskCheckpointableOffsets_private branch from 8ddd983 to 4e558fe Compare August 26, 2019 21:36
@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 27, 2019

JDK 11/Scala 2.12 failed with

org.scalatest.exceptions.TestFailedException: Consumed 0 records before timeout instead of the expected 1 records

Retest this, please

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 27, 2019

JDK 11/Scala 2.12 had the following failing test:

org.apache.kafka.streams.integration.StreamStreamJoinIntegrationTest.testOuterRepartitioned[caching enabled = true]

java.lang.AssertionError: Condition not met within timeout 60000. Did not receive all 1 records from topic outputTopic

Retest this, please

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 27, 2019

JDK 11/Scala 2.12 failed because the following test failed:

kafka.admin.DescribeConsumerGroupTest.testDescribeStateWithMultiPartitionTopicAndMultipleConsumers

JDK 11/Scala 2.13 failed because the following test failed:

org.apache.kafka.common.network.SslTransportLayerTest.testListenerConfigOverride

Retest this, please

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 28, 2019

In JDK 11/Scala 2.12 the following test failed:

org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSourceConnector

JDK 8/Scala 2.11 run into timeout after 4 hours.

Retest this, please

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 28, 2019

Retest this, please

@guozhangwang
Copy link
Copy Markdown
Contributor

LGTM!

@guozhangwang guozhangwang merged commit d2741e5 into apache:trunk Aug 29, 2019
@cadonna cadonna deleted the make_activeTaskCheckpointableOffsets_private branch October 21, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants