MINOR: Remove activeTaskCheckpointableOffsets from AbstractTask#7253
Merged
guozhangwang merged 1 commit intoapache:trunkfrom Aug 29, 2019
Merged
Conversation
Member
Author
|
Call for review: @cpettitt-confluent @mjsax @guozhangwang @bbejeck @vvcephei @ableegoldman @abbccdda |
3 tasks
Contributor
|
Verified this is only used in StreamTask. All for moving Stream/Standby specific stuff out of AbstractTask! LGTM. |
cpettitt-confluent
approved these changes
Aug 26, 2019
8ddd983 to
4e558fe
Compare
Member
Author
|
JDK 11/Scala 2.12 failed with Retest this, please |
Member
Author
|
JDK 11/Scala 2.12 had the following failing test: Retest this, please |
Member
Author
|
JDK 11/Scala 2.12 failed because the following test failed: JDK 11/Scala 2.13 failed because the following test failed: Retest this, please |
Member
Author
|
In JDK 11/Scala 2.12 the following test failed: JDK 8/Scala 2.11 run into timeout after 4 hours. Retest this, please |
Member
Author
|
Retest this, please |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)