Skip to content

MINOR: Remove activeTaskCheckpointableOffsets from AbstractTask #7253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 1 commit into from
Aug 29, 2019
Merged

MINOR: Remove activeTaskCheckpointableOffsets from AbstractTask #7253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@

import java.io.IOException;
import java.util.Collection;
import java.util.Collections;
import java.util.HashSet;
import java.util.Map;
import java.util.Set;

public abstract class AbstractTask implements Task {
Expand Down Expand Up @@ -173,10 +171,6 @@ public String toString(final String indent) {
return sb.toString();
}

protected Map<TopicPartition, Long> activeTaskCheckpointableOffsets() {
return Collections.emptyMap();
}

protected void updateOffsetLimits() {
for (final TopicPartition partition : partitions) {
try {
Expand Down
7 changes: 2 additions & 5 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,14 +484,11 @@ void commit(final boolean startNewTransaction) {
taskMetrics.taskCommitTimeSensor.record(time.nanoseconds() - startNs);
}

@Override
protected Map<TopicPartition, Long> activeTaskCheckpointableOffsets() {
final Map<TopicPartition, Long> checkpointableOffsets =
new HashMap<>(recordCollector.offsets());
private Map<TopicPartition, Long> activeTaskCheckpointableOffsets() {
final Map<TopicPartition, Long> checkpointableOffsets = new HashMap<>(recordCollector.offsets());
for (final Map.Entry<TopicPartition, Long> entry : consumedOffsets.entrySet()) {
checkpointableOffsets.putIfAbsent(entry.getKey(), entry.getValue());
}

return checkpointableOffsets;
}

Expand Down