Skip to content

KAFKA-9057: Backport KAFKA-8819 and KAFKA-8340 before 2.0#7549

Merged
rhauch merged 1 commit intoapache:1.1from
gharris1727:backport-classloader-fix
Oct 22, 2019
Merged

KAFKA-9057: Backport KAFKA-8819 and KAFKA-8340 before 2.0#7549
rhauch merged 1 commit intoapache:1.1from
gharris1727:backport-classloader-fix

Conversation

@gharris1727
Copy link
Copy Markdown
Contributor

  • Includes fixes from PR-7315
  • Omits ConfigProvider and Configurable test cases and plugins
  • Replaces Java 8 language features with suitable Java 7 features

Signed-off-by: Greg Harris gregh@confluent.io

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rhauch
Copy link
Copy Markdown
Contributor

rhauch commented Oct 21, 2019

Retest this, please.

* Includes fixes from PR-7315
* Omits ConfigProvider and Configurable test cases and plugins
* Replaces Java 8 language features with suitable Java 7 features

Signed-off-by: Greg Harris <gregh@confluent.io>
@gharris1727 gharris1727 force-pushed the backport-classloader-fix branch from 1426e42 to 27f3921 Compare October 22, 2019 15:34
@gharris1727
Copy link
Copy Markdown
Contributor Author

This is now rebased on top of #7572.

@rhauch
Copy link
Copy Markdown
Contributor

rhauch commented Oct 22, 2019

The JDK 8 and 10 had very few test failures, but all of them were unrelated to Connect.

Copy link
Copy Markdown
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for backporting, @gharris1727!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants