KAFKA-9057: Backport KAFKA-8819 and KAFKA-8340 to 1.0#7580
Merged
rhauch merged 2 commits intoapache:1.0from Oct 22, 2019
Merged
KAFKA-9057: Backport KAFKA-8819 and KAFKA-8340 to 1.0#7580rhauch merged 2 commits intoapache:1.0from
rhauch merged 2 commits intoapache:1.0from
Conversation
Includes fixes from PR-7315 (KAFKA-8819 and KAFKA-8340), but omits ConfigProvider and Configurable test cases and plugins, and replaces Java 8 language features with suitable Java 7 features. Signed-off-by: Greg Harris <gregh@confluent.io> Author: Greg Harris <gregh@confluent.io> Reviewer: Randall Hauch <rhauch@gmail.com> Signed-off-by: Greg Harris <gregh@confluent.io>
* Adding PluginsTest file which did not exist before * Removing Converter::configure test case * Removing HeaderConverter test plugin and test cases * Removing Converter Types test cases * Removing classloader control test cases Signed-off-by: Greg Harris <gregh@confluent.io>
rhauch
approved these changes
Oct 22, 2019
Contributor
rhauch
left a comment
rhauch
left a comment
There was a problem hiding this comment.
LGTM. Thanks for backporting, @gharris1727!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the fix from #7315 , but backported to be compatible with 1.0
Changes to this PR since #7549 are mostly in Plugins and PluginsTest.
Committer Checklist (excluded from commit message)