Skip to content

KAFKA-7489: Backport fix ConnectDistributedTest system test to use KafkaVersion#7791

Merged
rhauch merged 1 commit intoapache:2.3from
rhauch:kafka-7489
Dec 6, 2019
Merged

KAFKA-7489: Backport fix ConnectDistributedTest system test to use KafkaVersion#7791
rhauch merged 1 commit intoapache:2.3from
rhauch:kafka-7489

Conversation

@rhauch
Copy link
Copy Markdown
Contributor

@rhauch rhauch commented Dec 6, 2019

This was fixed in 2.4 and trunk per #7023, but the use of KafkaVersion should have been backported. This commit makes this change on 2.3, and should be backported to 2.2 and 2.1.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rhauch
Copy link
Copy Markdown
Contributor Author

rhauch commented Dec 6, 2019

@rhauch
Copy link
Copy Markdown
Contributor Author

rhauch commented Dec 6, 2019

Aforementioned Connect-only system test run on this PR branch passed. Waiting for review and normal PR builds - tho this PR is a system test change that shouldn't affect the normal builds.

Copy link
Copy Markdown
Contributor

@ncliang ncliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @rhauch

@rhauch rhauch merged commit dcbc6c5 into apache:2.3 Dec 6, 2019
rhauch added a commit that referenced this pull request Dec 6, 2019
…n (backport) (#7791)

Author: Randall Hauch <rhauch@gmail.com>
Reviewers: Nigel Liang <nigel@nigelliang.com>, John Roesler <john@confluent.io>
rhauch added a commit that referenced this pull request Dec 6, 2019
…n (backport) (#7791)

Author: Randall Hauch <rhauch@gmail.com>
Reviewers: Nigel Liang <nigel@nigelliang.com>, John Roesler <john@confluent.io>
gharris1727 added a commit to gharris1727/kafka that referenced this pull request Feb 3, 2020
(apache#7023) exposed an incompatibility between Kafka <=0.9 and Connect >0.9,
in which the broker does not recognize a request for ApiVersions.
For trunk and 2.4, this test case was removed rather than the issue addressed.
This effectively backports the other half of (apache#7023) which was left out of (apache#7791).

Signed-off-by: Greg Harris <gregh@confluent.io>
rhauch pushed a commit that referenced this pull request Feb 5, 2020
…DistributedTest (#8035)

(#7023) exposed an incompatibility between Kafka <=0.9 and Connect >0.9,
in which the broker does not recognize a request for ApiVersions.
For trunk and 2.4, this test case was removed rather than the issue addressed.
This effectively backports the other half of (#7023) which was left out of (#7791).

Signed-off-by: Greg Harris <gregh@confluent.io>

Author: Greg Harris <gregh@confluent.io>
Reviewers: Randall Hauch <rhauch@gmail.com>, Andrew Choi <andchoi@linkedin.com>
rhauch pushed a commit that referenced this pull request Feb 5, 2020
…DistributedTest (#8035)

(#7023) exposed an incompatibility between Kafka <=0.9 and Connect >0.9,
in which the broker does not recognize a request for ApiVersions.
For trunk and 2.4, this test case was removed rather than the issue addressed.
This effectively backports the other half of (#7023) which was left out of (#7791).

Signed-off-by: Greg Harris <gregh@confluent.io>

Author: Greg Harris <gregh@confluent.io>
Reviewers: Randall Hauch <rhauch@gmail.com>, Andrew Choi <andchoi@linkedin.com>
rhauch pushed a commit that referenced this pull request Feb 5, 2020
…DistributedTest (#8035)

(#7023) exposed an incompatibility between Kafka <=0.9 and Connect >0.9,
in which the broker does not recognize a request for ApiVersions.
For trunk and 2.4, this test case was removed rather than the issue addressed.
This effectively backports the other half of (#7023) which was left out of (#7791).

Signed-off-by: Greg Harris <gregh@confluent.io>

Author: Greg Harris <gregh@confluent.io>
Reviewers: Randall Hauch <rhauch@gmail.com>, Andrew Choi <andchoi@linkedin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants