KAFKA-7489: Remove 0.9 compatibility checks from ConnectDistributedTest#8035
Merged
rhauch merged 1 commit intoapache:2.3from Feb 5, 2020
Merged
KAFKA-7489: Remove 0.9 compatibility checks from ConnectDistributedTest#8035rhauch merged 1 commit intoapache:2.3from
rhauch merged 1 commit intoapache:2.3from
Conversation
(apache#7023) exposed an incompatibility between Kafka <=0.9 and Connect >0.9, in which the broker does not recognize a request for ApiVersions. For trunk and 2.4, this test case was removed rather than the issue addressed. This effectively backports the other half of (apache#7023) which was left out of (apache#7791). Signed-off-by: Greg Harris <gregh@confluent.io>
Contributor
Author
rhauch
approved these changes
Feb 3, 2020
Contributor
rhauch
left a comment
rhauch
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @gharris1727
Contributor
|
ok to test |
andrewchoi5
approved these changes
Feb 3, 2020
Contributor
|
This PR changes only the system tests, and the (non-system test) build failures are completely unrelated. |
Contributor
Author
|
System test branch builder: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3733/ |
andrewchoi5
approved these changes
Feb 5, 2020
rhauch
pushed a commit
that referenced
this pull request
Feb 5, 2020
…DistributedTest (#8035) (#7023) exposed an incompatibility between Kafka <=0.9 and Connect >0.9, in which the broker does not recognize a request for ApiVersions. For trunk and 2.4, this test case was removed rather than the issue addressed. This effectively backports the other half of (#7023) which was left out of (#7791). Signed-off-by: Greg Harris <gregh@confluent.io> Author: Greg Harris <gregh@confluent.io> Reviewers: Randall Hauch <rhauch@gmail.com>, Andrew Choi <andchoi@linkedin.com>
rhauch
pushed a commit
that referenced
this pull request
Feb 5, 2020
…DistributedTest (#8035) (#7023) exposed an incompatibility between Kafka <=0.9 and Connect >0.9, in which the broker does not recognize a request for ApiVersions. For trunk and 2.4, this test case was removed rather than the issue addressed. This effectively backports the other half of (#7023) which was left out of (#7791). Signed-off-by: Greg Harris <gregh@confluent.io> Author: Greg Harris <gregh@confluent.io> Reviewers: Randall Hauch <rhauch@gmail.com>, Andrew Choi <andchoi@linkedin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(#7023) exposed an incompatibility between Kafka <=0.9 and Connect >0.9,
in which the broker does not recognize a request for ApiVersions.
For trunk and 2.4, this test case was removed rather than the issue addressed.
This effectively backports the other half of (#7023) which was left out of (#7791).
Signed-off-by: Greg Harris gregh@confluent.io
It is necessary to backport this to all of the branches that #7791 was backported to, namely
2.2and2.1.Committer Checklist (excluded from commit message)