DOCS - clarify transactionalID and idempotent behavior#7821
Merged
guozhangwang merged 2 commits intoapache:trunkfrom Feb 7, 2020
Merged
DOCS - clarify transactionalID and idempotent behavior#7821guozhangwang merged 2 commits intoapache:trunkfrom
guozhangwang merged 2 commits intoapache:trunkfrom
Conversation
Contributor
Author
|
ping @guozhangwang |
ghost
reviewed
Dec 31, 2019
| public static final String TRANSACTIONAL_ID_DOC = "The TransactionalId to use for transactional delivery. This enables reliability semantics which span multiple producer sessions since it allows the client to guarantee that transactions using the same TransactionalId have been completed prior to starting any new transactions. If no TransactionalId is provided, then the producer is limited to idempotent delivery. " + | ||
| "Note that <code>enable.idempotence</code> must be enabled if a TransactionalId is configured. " + | ||
| "If a TransactionalId is configured, <code>enable.idempotence</code> is implied. " + | ||
| "The default is <code>null</code>, which means transactions cannot be used. " + |
There was a problem hiding this comment.
The default is <code>null</code> - I don't think this is clear enough, is it talking about the default for TransactionalId or the default for enable.idempotence?
guozhangwang
reviewed
Jan 1, 2020
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
Other than @WheresAlice 's comment this PR LGTM. Maybe we can just say ".. is implied as true. By default TransactionId is not configured, which means ..."
Contributor
Author
|
@WheresAlice @guozhangwang i have updated per feedback fa61ea0 |
|
LGTM |
Contributor
Author
|
ping @guozhangwang for merge |
guozhangwang
approved these changes
Feb 7, 2020
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Apr 28, 2020
…t-for-generated-requests * apache-github/trunk: (410 commits) KAFKA-8843: KIP-515: Zookeeper TLS support MINOR: Add missing quote for malformed line content (apache#8070) MINOR: Simplify KafkaProducerTest (apache#8044) KAFKA-9507; AdminClient should check for missing committed offsets (apache#8057) KAFKA-9519: Deprecate the --zookeeper flag in ConfigCommand (apache#8056) KAFKA-9509; Fixing flakiness of MirrorConnectorsIntegrationTest.testReplication (apache#8048) HOTFIX: Fix two test failures in JDK11 (apache#8063) DOCS - clarify transactionalID and idempotent behavior (apache#7821) MINOR: further InternalTopologyBuilder cleanup (apache#8046) MINOR: Add timer for update limit offsets (apache#8047) HOTFIX: Fix spotsbug failure in Kafka examples (apache#8051) KAFKA-9447: Add new customized EOS model example (apache#8031) KAFKA-8164: Add support for retrying failed (apache#8019) HOTFIX: checkstyle for newly added unit test KAFKA-9261; Client should handle unavailable leader metadata (apache#7770) MINOR: Fix typos introduced in KIP-559 (apache#8042) MINOR: Fixing null handilg in ValueAndTimestampSerializer (apache#7679) KAFKA-9113: Clean up task management and state management (apache#7997) MINOR: fix checkstyle issue in ConsumerConfig.java (apache#8038) KAFKA-9491; Increment high watermark after full log truncation (apache#8037) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If transactional.id is set without setting enable.idempotence, the producer will set enable.idempotence to true implicitly. The docs should reflect this.
Committer Checklist (excluded from commit message)