Skip to content

HOTFIX: Fix two test failures in JDK11#8063

Merged
guozhangwang merged 2 commits intoapache:trunkfrom
guozhangwang:KMinor-J11-failed-tests
Feb 7, 2020
Merged

HOTFIX: Fix two test failures in JDK11#8063
guozhangwang merged 2 commits intoapache:trunkfrom
guozhangwang:KMinor-J11-failed-tests

Conversation

@guozhangwang
Copy link
Copy Markdown
Contributor

@guozhangwang guozhangwang commented Feb 7, 2020

  1. StoreChangelogReaderTest.shouldRequestCommittedOffsetsAndHandleTimeoutException[1] This is due to stricter ternary operator type casting

  2. KStreamImplTest.shouldSupportTriggerMaterializedWithKTableFromKStream
    This is added recently where String typed values for <String, Integer>, in J8 it is allowed but in J11 it is not allowed.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

vvcephei
vvcephei approved these changes Feb 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! There’s just one debugging artifact to remove before merging.

Comment thread streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java Outdated
final HashMap<String, String> result = new HashMap<>();
store.all().forEachRemaining(kv -> result.put(kv.key, kv.value));
store.all().forEachRemaining(kv -> {
System.out.println(kv);
Copy link
Copy Markdown
Contributor

@vvcephei vvcephei Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove this println?

Copy link
Copy Markdown
Contributor Author

@guozhangwang guozhangwang Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes! thanks.

@guozhangwang guozhangwang merged commit a6c9e96 into apache:trunk Feb 7, 2020
mjsax added a commit to mjsax/kafka that referenced this pull request Feb 8, 2020
@mjsax
Partly revert HOTFIX (apache#8063) that seems not to be the correct fix
295398d
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Feb 8, 2020

@guozhangwang @vvcephei I don't think that the fix for KStreamImplTest.shouldSupportTriggerMaterializedWithKTableFromKStream is the best -- I actually included a fix in #8027 already. I discovered this PR due to merge conflicts. Let me know what you think about the fix I propose: from my understanding, the issue in non-types asMap() method (using proper generics in my PR): https://github.com/apache/kafka/pull/8027/files#diff-ff79389c67cd62a86556f148a84b4871L2958-R2967

Hence, I think we should fix asMap() but keep the Integer value type.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Feb 9, 2020

Yeah, I agree that the fix to change the value type from Integer to String seems weird.

@guozhangwang guozhangwang deleted the KMinor-J11-failed-tests branch April 24, 2020 23:52
ijuma added a commit to ijuma/kafka that referenced this pull request Apr 28, 2020
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into skip-to-struc…
186aad4 
…t-for-generated-requests

* apache-github/trunk: (410 commits)
  KAFKA-8843: KIP-515: Zookeeper TLS support
  MINOR: Add missing quote for malformed line content (apache#8070)
  MINOR: Simplify KafkaProducerTest (apache#8044)
  KAFKA-9507; AdminClient should check for missing committed offsets (apache#8057)
  KAFKA-9519: Deprecate the --zookeeper flag in ConfigCommand (apache#8056)
  KAFKA-9509; Fixing flakiness of MirrorConnectorsIntegrationTest.testReplication (apache#8048)
  HOTFIX: Fix two test failures in JDK11 (apache#8063)
  DOCS - clarify transactionalID and idempotent behavior (apache#7821)
  MINOR: further InternalTopologyBuilder cleanup  (apache#8046)
  MINOR: Add timer for update limit offsets (apache#8047)
  HOTFIX: Fix spotsbug failure in Kafka examples (apache#8051)
  KAFKA-9447: Add new customized EOS model example (apache#8031)
  KAFKA-8164: Add support for retrying failed (apache#8019)
  HOTFIX: checkstyle for newly added unit test
  KAFKA-9261; Client should handle unavailable leader metadata (apache#7770)
  MINOR: Fix typos introduced in KIP-559 (apache#8042)
  MINOR: Fixing null handilg in ValueAndTimestampSerializer (apache#7679)
  KAFKA-9113: Clean up task management and state management (apache#7997)
  MINOR: fix checkstyle issue in ConsumerConfig.java (apache#8038)
  KAFKA-9491; Increment high watermark after full log truncation (apache#8037)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vvcephei vvcephei vvcephei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guozhangwang @mjsax @ijuma @vvcephei