Skip to content

KAFKA-9343: Add ps command for Kafka and zookeeper process on z/OS.#7913

Merged
mimaison merged 3 commits intoapache:trunkfrom
zshuo:shell4z
Feb 20, 2020
Merged

KAFKA-9343: Add ps command for Kafka and zookeeper process on z/OS.#7913
mimaison merged 3 commits intoapache:trunkfrom
zshuo:shell4z

Conversation

@zshuo
Copy link
Copy Markdown
Contributor

@zshuo zshuo commented Jan 9, 2020

KAFKA-9343: Make Kafka shell runnable on z/OS

Finished both unit and integration test, and check

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@zshuo
Copy link
Copy Markdown
Contributor Author

zshuo commented Jan 10, 2020

@mimaison Could you please help review this? Thanks!

@mimaison
Copy link
Copy Markdown
Member

@zshuo Thanks for the PR. This change are a bit "heavy-handed" considering z/OS is a niche platform for Kafka.

Instead of updating the Kafka scripts, it's probably easier to update the bash version in your environment. You can install bash 4.2 and the scripts should work fine once converted to EBCDIC.

@zshuo
Copy link
Copy Markdown
Contributor Author

zshuo commented Feb 4, 2020

@mimaison Could you please help review again? Thanks!

Copy link
Copy Markdown
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I've left a couple of comments

Comment thread bin/kafka-server-stop.sh Outdated
Comment thread bin/zookeeper-server-stop.sh Outdated
@zshuo
Copy link
Copy Markdown
Contributor Author

zshuo commented Feb 7, 2020

Thanks, it is a good suggestion, @mimaison, I updated.

@zshuo zshuo requested a review from mimaison February 11, 2020 06:51
@mimaison mimaison merged commit 6d4cfad into apache:trunk Feb 20, 2020
ijuma added a commit to confluentinc/kafka that referenced this pull request Feb 24, 2020
* apache-github/trunk: (23 commits)
  KAFKA-9530; Fix flaky test `testDescribeGroupWithShortInitializationTimeout` (apache#8154)
  HOTFIX: fix NPE in Kafka Streams IQ (apache#8158)
  MINOR: set scala version automatically based on gradle.properties
  KAFKA-9577; SaslClientAuthenticator incorrectly negotiates SASL_HANDSHAKE version (apache#8142)
  KAFKA-9441: Add internal TransactionManager (apache#8105)
  MINOR: Document endpoints for connector topic tracking (KIP-558)
  MINOR: Standby task commit needed when offsets updated (apache#8146)
  KAFKA-9206; Throw KafkaException on CORRUPT_MESSAGE error in Fetch response (apache#8111)
  MINOR: Remove unwanted regexReplace on tests/kafkatest/__init__.py
  KAFKA-9586: Fix errored json filename in ops documentation
  KAFKA-9575: Mention ZooKeeper 3.5.7 upgrade
  KAFKA-9481: Graceful handling TaskMigrated and TaskCorrupted (apache#8058)
  HOTFIX: don't try to remove uninitialized changelogs from assignment & don't prematurely mark task closed (apache#8140)
  MINOR: Fix javadoc at org.apache.kafka.clients.producer.KafkaProducer.InterceptorCallback#onCompletion (apache#7337)
  MINOR: Improve EOS example exception handling (apache#8052)
  MINOR: Fix a number of warnings in clients test (apache#8073)
  MINOR: Update shell scripts to support z/OS system (apache#7913)
  MINOR: Wording fix in Streams DSL docs (apache#5692)
  MINOR: Add missing @test annotation to MetadataTest#testMetadataMerge (apache#8141)
  KAFKA-9533: ValueTransform forwards `null` values (apache#8108)
  ...
ijuma added a commit to confluentinc/kafka that referenced this pull request Feb 24, 2020
…etrics-common

* confluent/master: (76 commits)
  KAFKA-9530; Fix flaky test `testDescribeGroupWithShortInitializationTimeout` (apache#8154)
  HOTFIX: fix NPE in Kafka Streams IQ (apache#8158)
  MINOR: set scala version automatically based on gradle.properties
  KAFKA-9577; SaslClientAuthenticator incorrectly negotiates SASL_HANDSHAKE version (apache#8142)
  KAFKA-9441: Add internal TransactionManager (apache#8105)
  MINOR: Document endpoints for connector topic tracking (KIP-558)
  MINOR: Standby task commit needed when offsets updated (apache#8146)
  Changes to migrate to Artifactory (#263)
  KAFKA-9206; Throw KafkaException on CORRUPT_MESSAGE error in Fetch response (apache#8111)
  MINOR: Remove unwanted regexReplace on tests/kafkatest/__init__.py
  KAFKA-9586: Fix errored json filename in ops documentation
  KAFKA-9575: Mention ZooKeeper 3.5.7 upgrade
  KAFKA-9481: Graceful handling TaskMigrated and TaskCorrupted (apache#8058)
  HOTFIX: don't try to remove uninitialized changelogs from assignment & don't prematurely mark task closed (apache#8140)
  MINOR: Fix javadoc at org.apache.kafka.clients.producer.KafkaProducer.InterceptorCallback#onCompletion (apache#7337)
  MINOR: Improve EOS example exception handling (apache#8052)
  MINOR: Fix a number of warnings in clients test (apache#8073)
  MINOR: Update shell scripts to support z/OS system (apache#7913)
  MINOR: Wording fix in Streams DSL docs (apache#5692)
  MINOR: Add missing @test annotation to MetadataTest#testMetadataMerge (apache#8141)
  ...
@zshuo zshuo changed the title Update shell scripts to support z/OS system Add ps command for Kafka and zookeeper process on z/OS. Mar 11, 2020
@zshuo zshuo changed the title Add ps command for Kafka and zookeeper process on z/OS. KAFKA-9343: Add ps command for Kafka and zookeeper process on z/OS. Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants