Skip to content

HOTFIX: fix NPE in Kafka Streams IQ#8158

Merged
mjsax merged 1 commit intoapache:trunkfrom
mjsax:hotfix-iq
Feb 23, 2020
Merged

HOTFIX: fix NPE in Kafka Streams IQ#8158
mjsax merged 1 commit intoapache:trunkfrom
mjsax:hotfix-iq

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Feb 22, 2020

Reported on the mailing list. Would be good to get this into 2.5.0, too. If not, also ok. (\cc @arvindth)

Call for review @vvcephei @guozhangwang @brary @vitojeng @vinothchandar @vpapavas

@mjsax mjsax added the streams label Feb 22, 2020
mjsax
mjsax commented Feb 22, 2020
View reviewed changes
Comment thread ...c/test/java/org/apache/kafka/streams/state/internals/StreamThreadStateStoreProviderTest.java
}

@Test
public void shouldReturnSingleStoreForPartition() {
Copy link
Copy Markdown
Member Author

@mjsax mjsax Feb 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first two tests are just new test that we missed to add in the original PR.

vitojeng
vitojeng approved these changes Feb 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vitojeng vitojeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Feb 22, 2020

LGTM! Just clarifying that this NPE can only be thrown if the user passed in partition number in param that does not exist, right?

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Feb 23, 2020

this NPE can only be thrown if the user passed in partition number in param that does not exist, right?

Correct.

@mjsax mjsax merged commit 7d504d6 into apache:trunk Feb 23, 2020
@mjsax mjsax deleted the hotfix-iq branch February 23, 2020 12:08
mjsax added a commit that referenced this pull request Feb 23, 2020
@mjsax
HOTFIX: fix NPE in Kafka Streams IQ (#8158)
139714b 
Reviewers: Vito Jeng <vito@is-land.com.tw>, Guozhang Wang <guozhang@confluent.io>
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Feb 23, 2020

Merged to trunk and cherry-picked to 2.5.

ijuma added a commit to confluentinc/kafka that referenced this pull request Feb 24, 2020
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into ccs-master
38dec03 
* apache-github/trunk: (23 commits)
  KAFKA-9530; Fix flaky test `testDescribeGroupWithShortInitializationTimeout` (apache#8154)
  HOTFIX: fix NPE in Kafka Streams IQ (apache#8158)
  MINOR: set scala version automatically based on gradle.properties
  KAFKA-9577; SaslClientAuthenticator incorrectly negotiates SASL_HANDSHAKE version (apache#8142)
  KAFKA-9441: Add internal TransactionManager (apache#8105)
  MINOR: Document endpoints for connector topic tracking (KIP-558)
  MINOR: Standby task commit needed when offsets updated (apache#8146)
  KAFKA-9206; Throw KafkaException on CORRUPT_MESSAGE error in Fetch response (apache#8111)
  MINOR: Remove unwanted regexReplace on tests/kafkatest/__init__.py
  KAFKA-9586: Fix errored json filename in ops documentation
  KAFKA-9575: Mention ZooKeeper 3.5.7 upgrade
  KAFKA-9481: Graceful handling TaskMigrated and TaskCorrupted (apache#8058)
  HOTFIX: don't try to remove uninitialized changelogs from assignment & don't prematurely mark task closed (apache#8140)
  MINOR: Fix javadoc at org.apache.kafka.clients.producer.KafkaProducer.InterceptorCallback#onCompletion (apache#7337)
  MINOR: Improve EOS example exception handling (apache#8052)
  MINOR: Fix a number of warnings in clients test (apache#8073)
  MINOR: Update shell scripts to support z/OS system (apache#7913)
  MINOR: Wording fix in Streams DSL docs (apache#5692)
  MINOR: Add missing @test annotation to MetadataTest#testMetadataMerge (apache#8141)
  KAFKA-9533: ValueTransform forwards `null` values (apache#8108)
  ...
ijuma added a commit to confluentinc/kafka that referenced this pull request Feb 24, 2020
@ijuma
Merge remote-tracking branch 'confluent/master' into remove-support-m…
9f774d7 
…etrics-common

* confluent/master: (76 commits)
  KAFKA-9530; Fix flaky test `testDescribeGroupWithShortInitializationTimeout` (apache#8154)
  HOTFIX: fix NPE in Kafka Streams IQ (apache#8158)
  MINOR: set scala version automatically based on gradle.properties
  KAFKA-9577; SaslClientAuthenticator incorrectly negotiates SASL_HANDSHAKE version (apache#8142)
  KAFKA-9441: Add internal TransactionManager (apache#8105)
  MINOR: Document endpoints for connector topic tracking (KIP-558)
  MINOR: Standby task commit needed when offsets updated (apache#8146)
  Changes to migrate to Artifactory (#263)
  KAFKA-9206; Throw KafkaException on CORRUPT_MESSAGE error in Fetch response (apache#8111)
  MINOR: Remove unwanted regexReplace on tests/kafkatest/__init__.py
  KAFKA-9586: Fix errored json filename in ops documentation
  KAFKA-9575: Mention ZooKeeper 3.5.7 upgrade
  KAFKA-9481: Graceful handling TaskMigrated and TaskCorrupted (apache#8058)
  HOTFIX: don't try to remove uninitialized changelogs from assignment & don't prematurely mark task closed (apache#8140)
  MINOR: Fix javadoc at org.apache.kafka.clients.producer.KafkaProducer.InterceptorCallback#onCompletion (apache#7337)
  MINOR: Improve EOS example exception handling (apache#8052)
  MINOR: Fix a number of warnings in clients test (apache#8073)
  MINOR: Update shell scripts to support z/OS system (apache#7913)
  MINOR: Wording fix in Streams DSL docs (apache#5692)
  MINOR: Add missing @test annotation to MetadataTest#testMetadataMerge (apache#8141)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vitojeng vitojeng vitojeng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjsax @guozhangwang @vitojeng