Skip to content

KAFKA-9152; Improve Sensor Retrieval#7914

Closed
highluck wants to merge 1 commit intoapache:trunkfrom
highluck:improve-sensor
Closed

KAFKA-9152; Improve Sensor Retrieval#7914
highluck wants to merge 1 commit intoapache:trunkfrom
highluck:improve-sensor

Conversation

@highluck
Copy link
Copy Markdown
Contributor

@highluck highluck commented Jan 9, 2020

Fixed to save only when there is no space for efficiency :)

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@bbejeck bbejeck added the streams label Jan 9, 2020
Copy link
Copy Markdown
Member

@cadonna cadonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@highluck Thank you for your PR

You also need to adapt the unit tests in StreamsMetricsImplTest.

Here my comments.

@highluck highluck closed this Jan 10, 2020
@highluck highluck deleted the improve-sensor branch January 10, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants