Skip to content

KAFKA-9152; Improve Sensor Retrieval #7914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
highluck wants to merge 1 commit into from
Closed

KAFKA-9152; Improve Sensor Retrieval #7914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 36 additions & 30 deletions ...rc/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import java.util.Objects;
import java.util.concurrent.TimeUnit;
import java.util.function.Supplier;
import java.util.Optional;

public class StreamsMetricsImpl implements StreamsMetrics {

Expand Down Expand Up @@ -210,10 +211,14 @@ public final Sensor threadLevelSensor(final String threadId,
final Sensor... parents) {
final String key = threadSensorPrefix(threadId);
synchronized (threadLevelSensors) {
threadLevelSensors.putIfAbsent(key, new LinkedList<>());
final String fullSensorName = key + SENSOR_NAME_DELIMITER + sensorName;
final Sensor sensor = metrics.sensor(fullSensorName, recordingLevel, parents);
threadLevelSensors.get(key).push(fullSensorName);
final Sensor sensor = Optional.ofNullable(metrics.getSensor(fullSensorName))
.orElseGet(() -> {
threadLevelSensors.putIfAbsent(key, new LinkedList<>());
final Sensor newSensor = metrics.sensor(fullSensorName, recordingLevel, parents);
threadLevelSensors.get(key).push(fullSensorName);
return newSensor;
});
Comment thread
highluck marked this conversation as resolved.
return sensor;
}
}
Expand Down Expand Up @@ -290,12 +295,14 @@ public final Sensor taskLevelSensor(final String threadId,
final Sensor... parents) {
final String key = taskSensorPrefix(threadId, taskId);
synchronized (taskLevelSensors) {
if (!taskLevelSensors.containsKey(key)) {
taskLevelSensors.put(key, new LinkedList<>());
}
final String fullSensorName = key + SENSOR_NAME_DELIMITER + sensorName;
final Sensor sensor = metrics.sensor(fullSensorName, recordingLevel, parents);
taskLevelSensors.get(key).push(fullSensorName);
final Sensor sensor = Optional.ofNullable(metrics.getSensor(fullSensorName))
.orElseGet(() -> {
taskLevelSensors.putIfAbsent(key, new LinkedList<>());
final Sensor newSensor = metrics.sensor(fullSensorName, recordingLevel, parents);
taskLevelSensors.get(key).push(fullSensorName);
return newSensor;
});
return sensor;
}
}
Expand Down Expand Up @@ -323,15 +330,14 @@ public Sensor nodeLevelSensor(final String threadId,
final Sensor... parents) {
final String key = nodeSensorPrefix(threadId, taskId, processorNodeName);
synchronized (nodeLevelSensors) {
if (!nodeLevelSensors.containsKey(key)) {
nodeLevelSensors.put(key, new LinkedList<>());
}

final String fullSensorName = key + SENSOR_NAME_DELIMITER + sensorName;

final Sensor sensor = metrics.sensor(fullSensorName, recordingLevel, parents);

nodeLevelSensors.get(key).push(fullSensorName);
final Sensor sensor = Optional.ofNullable(metrics.getSensor(fullSensorName))
.orElseGet(() -> {
nodeLevelSensors.putIfAbsent(key, new LinkedList<>());
final Sensor newSensor = metrics.sensor(fullSensorName, recordingLevel, parents);
nodeLevelSensors.get(key).push(fullSensorName);
return newSensor;
});

return sensor;
}
Expand Down Expand Up @@ -362,15 +368,14 @@ public Sensor cacheLevelSensor(final String threadId,
final Sensor... parents) {
final String key = cacheSensorPrefix(threadId, taskName, storeName);
synchronized (cacheLevelSensors) {
if (!cacheLevelSensors.containsKey(key)) {
cacheLevelSensors.put(key, new LinkedList<>());
}

final String fullSensorName = key + SENSOR_NAME_DELIMITER + sensorName;

final Sensor sensor = metrics.sensor(fullSensorName, recordingLevel, parents);

cacheLevelSensors.get(key).push(fullSensorName);
final Sensor sensor = Optional.ofNullable(metrics.getSensor(fullSensorName))
.orElseGet(() -> {
cacheLevelSensors.putIfAbsent(key, new LinkedList<>());
final Sensor newSensor = metrics.sensor(fullSensorName, recordingLevel, parents);
cacheLevelSensors.get(key).push(fullSensorName);
return newSensor;
});

return sensor;
}
Expand Down Expand Up @@ -413,13 +418,14 @@ public final Sensor storeLevelSensor(final String threadId,
final Sensor... parents) {
final String key = storeSensorPrefix(threadId, taskId, storeName);
synchronized (storeLevelSensors) {
if (!storeLevelSensors.containsKey(key)) {
storeLevelSensors.put(key, new LinkedList<>());
}
final String fullSensorName = key + SENSOR_NAME_DELIMITER + sensorName;
final Sensor sensor = metrics.sensor(fullSensorName, recordingLevel, parents);

storeLevelSensors.get(key).push(fullSensorName);
final Sensor sensor = Optional.ofNullable(metrics.getSensor(fullSensorName))
.orElseGet(() -> {
storeLevelSensors.putIfAbsent(key, new LinkedList<>());
final Sensor newSensor = metrics.sensor(fullSensorName, recordingLevel, parents);
storeLevelSensors.get(key).push(fullSensorName);
return newSensor;
});

return sensor;
}
Expand Down