Skip to content

MINOR: Remove Diamond and code code Alignment#8107

Merged
abbccdda merged 2 commits intoapache:trunkfrom
highluck:code
Jun 26, 2020
Merged

MINOR: Remove Diamond and code code Alignment#8107
abbccdda merged 2 commits intoapache:trunkfrom
highluck:code

Conversation

@highluck
Copy link
Copy Markdown
Contributor

@highluck highluck commented Feb 13, 2020

Remove Diamond and code code Alignment

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@highluck highluck requested a review from vvcephei February 13, 2020 16:02
abbccdda
abbccdda reviewed Feb 13, 2020
View reviewed changes
Copy link
Copy Markdown

@abbccdda abbccdda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. Not sure we need to have this as a standalone PR though as we could do the cleanup when we actually touch these files, let @vvcephei make a call.

vvcephei
vvcephei approved these changes May 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @highluck , I'm really sorry; I didn't see this PR until just now.

Thanks for the cleanup. If you want to rebase, I can give it another look and merge it.

@highluck
Copy link
Copy Markdown
Contributor Author

highluck commented Jun 4, 2020

@vvcephei
code update!

@vvcephei
Copy link
Copy Markdown
Contributor

vvcephei commented Jun 4, 2020

Ok to test

vvcephei
vvcephei approved these changes Jun 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @highluck ; just waiting on tests.

@highluck
Copy link
Copy Markdown
Contributor Author

highluck commented Jun 21, 2020

@vvcephei
Could you please check again?

@abbccdda
Copy link
Copy Markdown

abbccdda commented Jun 23, 2020

retest this please

abbccdda
abbccdda approved these changes Jun 26, 2020
View reviewed changes
Copy link
Copy Markdown

@abbccdda abbccdda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbccdda abbccdda merged commit 43f4b1b into apache:trunk Jun 26, 2020
Kvicii pushed a commit to Kvicii/kafka that referenced this pull request Jun 27, 2020
Merge branch 'trunk' of github.com:apache/kafka into trunk-read
b4f5fd8 
* 'trunk' of github.com:apache/kafka:
  KAFKA-10180: Fix security_config caching in system tests (apache#8917)
  KAFKA-10173: Fix suppress changelog binary schema compatibility (apache#8905)
  KAFKA-10166: always write checkpoint before closing an (initialized) task (apache#8926)
  MINOR: Rename SslTransportLayer.State."NOT_INITALIZED" enum value to "NOT_INITIALIZED"
  MINOR: Update Scala to 2.13.3 (apache#8931)
  KAFKA-9076: support consumer sync across clusters in MM 2.0 (apache#7577)
  MINOR: Remove Diamond and code code Alignment (apache#8107)
  KAFKA-10198: guard against recycling dirty state (apache#8924)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vvcephei vvcephei vvcephei approved these changes

@abbccdda abbccdda abbccdda approved these changes

Assignees

No one assigned

Labels

streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@highluck @vvcephei @abbccdda