KAFKA-10180: Fix security_config caching.#8917
Merged
junrao merged 1 commit intoapache:trunkfrom Jun 27, 2020
Merged
Conversation
Contributor
Author
|
Hello, @rondagostino @ijuma Please, take a look. |
Contributor
|
Results of the system tests: Down to 13 failures and all benchmark related failures are gone. http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-06-26--001.1593223563--nizhikov--KAFKA-10180--ba1dee62e/report.html |
Contributor
|
@rhauch : This PR may fix a bunch of system tests in 2.6 too. Since 2.6.0 is code freeze now, I will let you decide if you want to merge this PR to 2.6. |
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
Jun 27, 2020
* 'trunk' of github.com:apache/kafka: KAFKA-10180: Fix security_config caching in system tests (apache#8917) KAFKA-10173: Fix suppress changelog binary schema compatibility (apache#8905) KAFKA-10166: always write checkpoint before closing an (initialized) task (apache#8926) MINOR: Rename SslTransportLayer.State."NOT_INITALIZED" enum value to "NOT_INITIALIZED" MINOR: Update Scala to 2.13.3 (apache#8931) KAFKA-9076: support consumer sync across clusters in MM 2.0 (apache#7577) MINOR: Remove Diamond and code code Alignment (apache#8107) KAFKA-10198: guard against recycling dirty state (apache#8924)
ijuma
pushed a commit
that referenced
this pull request
Jun 28, 2020
Reviewers: Jun Rao <junrao@gmail.com>
Member
|
We need this in 2.6 to ensure we have passing system tests, so I cherry-picked it to that branch. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 8b22b81
security_configproperties are modified duringsetup_node: tls_version patched according to the node jdk version. But python@propertydecorator doesn't store property values and fresh instance ofSecurityConfigcreated on eachkafka.security_configcallThis patch caches
SecurityConfiginstances so correct tls_version will be used during the test.Committer Checklist (excluded from commit message)