KAFKA-9670: Reduce allocations in Metadata Response preparation#8236
Merged
hachikuji merged 5 commits intoapache:trunkfrom Mar 16, 2020
Merged
KAFKA-9670: Reduce allocations in Metadata Response preparation#8236hachikuji merged 5 commits intoapache:trunkfrom
hachikuji merged 5 commits intoapache:trunkfrom
Conversation
Contributor
Author
|
Perf results of Benchmark tests: Old: New |
omkreddy
force-pushed
the
inefficient-metadata-building
branch
from
579344e to
d846111
Compare
ijuma
reviewed
Mar 6, 2020
Member
There was a problem hiding this comment.
Should we remove MetadataResponse.TopicMetadata altogether or does it add value?
Contributor
Author
There was a problem hiding this comment.
I think, we can continue to use MetadataResponse.TopicMetadata in some of the internal classes and tests. But I open to update/remove the classes the code required.
hachikuji
reviewed
Mar 12, 2020
Contributor
There was a problem hiding this comment.
nit: I'd suggest changing this to accept Errors so that we don't need all the annoying .code() calls.
Contributor
There was a problem hiding this comment.
nit: for ra bunch of these accessors, we can drop parenthesis.
Contributor
There was a problem hiding this comment.
nit: this looks misaligned
omkreddy
force-pushed
the
inefficient-metadata-building
branch
2 times, most recently
from
7ea70b2 to
3777b18
Compare
omkreddy
force-pushed
the
inefficient-metadata-building
branch
from
3777b18 to
ddd4825
Compare
Contributor
Author
|
@hachikuji Thanks for the review. Addressed the review comments. |
hachikuji
approved these changes
Mar 16, 2020
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the patch!
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Mar 17, 2020
* apache-github/trunk: (39 commits) MINOR: cleanup and add tests to StateDirectoryTest (apache#8304) HOTFIX: StateDirectoryTest should use Set instead of List (apache#8305) MINOR: Fix build and JavaDoc warnings (apache#8291) MINOR: Fix kafka.server.RequestQuotaTest missing new ApiKeys. (apache#8302) KAFKA-9712: Catch and handle exception thrown by reflections scanner (apache#8289) KAFKA-9670; Reduce allocations in Metadata Response preparation (apache#8236) MINOR: fix Scala 2.13 build error introduced in apache#8083 (apache#8301) MINOR: enforce non-negative invariant for checkpointed offsets (apache#8297) MINOR: comment apikey types in generated switch (apache#8201) MINOR: Fix typo in CreateTopicsResponse.json (apache#8300) KIP-546: Implement describeClientQuotas and alterClientQuotas. (apache#8083) KAFKA-6647: Do note delete the lock file while holding the lock (apache#8267) KAFKA-9677: Fix consumer fetch with small consume bandwidth quotas (apache#8290) KAFKA-9533: Fix JavaDocs of KStream.transformValues (apache#8298) MINOR: reuse pseudo-topic in FKJoin (apache#8296) KAFKA-6145: Pt 2. Include offset sums in subscription (apache#8246) KAFKA-9714; Eliminate unused reference to IBP in `TransactionStateManager` (apache#8293) KAFKA-9718; Don't log passwords for AlterConfigs in request logs (apache#8294) KAFKA-8768: DeleteRecords request/response automated protocol (apache#7957) KAFKA-9685: Solve Set concatenation perf issue in AclAuthorizer ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes intermediate conversions between
MetadataResponse.TopicMetadata=>MetadataResponseTopicandMetadataResponse.PartitionMetadata=>MetadataResponsePartitionobjects.There is 15-20% reduction in object allocations and 5-10% improvement in metadata request performance.
Committer Checklist (excluded from commit message)