Skip to content

HOTFIX: build error caused by DescribeClientQuotasRequest#8301

Merged
cmccabe merged 1 commit intoapache:trunkfrom
chia7712:hotfix_compile_error_DescribeClientQuotasRequest
Mar 16, 2020
Merged

HOTFIX: build error caused by DescribeClientQuotasRequest#8301
cmccabe merged 1 commit intoapache:trunkfrom
chia7712:hotfix_compile_error_DescribeClientQuotasRequest

Conversation

@chia7712
Copy link
Copy Markdown
Member

related to #8083

fix the build error and add some tests.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712
Copy link
Copy Markdown
Member Author

@bdbyrne @cmccabe FYI

@chia7712
Copy link
Copy Markdown
Member Author

chia7712 commented Mar 15, 2020

the following error happens on scala 2.13

22:15:32 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/core/src/main/scala/kafka/server/KafkaApis.scala:2825: overloaded method constructor DescribeClientQuotasResponse with alternatives:
22:15:32   (x$1: org.apache.kafka.common.protocol.types.Struct,x$2: Short)org.apache.kafka.common.requests.DescribeClientQuotasResponse <and>
22:15:32   (x$1: Int,x$2: Throwable)org.apache.kafka.common.requests.DescribeClientQuotasResponse <and>
22:15:32   (x$1: java.util.Map[org.apache.kafka.common.quota.ClientQuotaEntity,java.util.Map[String,Double]],x$2: Int)org.apache.kafka.common.requests.DescribeClientQuotasResponse
22:15:32  cannot be applied to (Iterable[(org.apache.kafka.common.quota.ClientQuotaEntity, Iterable[(String, Double)])], Int)
22:15:32         new DescribeClientQuotasResponse(result, requestThrottleMs))

the root cause is that the return type of mapValues is changed from Map to MapView on scala 2.13. Hence, the type of "toJava" is changed from Map to Iterable as well.

@bdbyrne
Copy link
Copy Markdown
Contributor

bdbyrne commented Mar 15, 2020

LGTM, thanks for the quick fix. @cmccabe can you merge please?

@chia7712 chia7712 force-pushed the hotfix_compile_error_DescribeClientQuotasRequest branch from ace1f62 to 6078ef1 Compare March 15, 2020 15:22
@bdbyrne
Copy link
Copy Markdown
Contributor

bdbyrne commented Mar 15, 2020

Just saw the compile fix too. Thank you.

@bdbyrne
Copy link
Copy Markdown
Contributor

bdbyrne commented Mar 15, 2020

I'll fix the kafka.server.RequestQuotaTest

@chia7712
Copy link
Copy Markdown
Member Author

the flaky is traced by #8302

@mimaison
Copy link
Copy Markdown
Member

retest this please

@cmccabe
Copy link
Copy Markdown
Contributor

cmccabe commented Mar 16, 2020

LGTM. I'll merge this to unblock Jenkins.

@cmccabe cmccabe merged commit 31659c3 into apache:trunk Mar 16, 2020
ijuma added a commit to confluentinc/kafka that referenced this pull request Mar 17, 2020
* apache-github/trunk: (39 commits)
  MINOR: cleanup and add tests to StateDirectoryTest (apache#8304)
  HOTFIX: StateDirectoryTest should use Set instead of List (apache#8305)
  MINOR: Fix build and JavaDoc warnings (apache#8291)
  MINOR: Fix kafka.server.RequestQuotaTest missing new ApiKeys. (apache#8302)
  KAFKA-9712: Catch and handle exception thrown by reflections scanner (apache#8289)
  KAFKA-9670; Reduce allocations in Metadata Response preparation (apache#8236)
  MINOR: fix Scala 2.13 build error introduced in apache#8083 (apache#8301)
  MINOR: enforce non-negative invariant for checkpointed offsets (apache#8297)
  MINOR: comment apikey types in generated switch (apache#8201)
  MINOR: Fix typo in CreateTopicsResponse.json (apache#8300)
  KIP-546: Implement describeClientQuotas and alterClientQuotas. (apache#8083)
  KAFKA-6647: Do note delete the lock file while holding the lock (apache#8267)
  KAFKA-9677: Fix consumer fetch with small consume bandwidth quotas (apache#8290)
  KAFKA-9533: Fix JavaDocs of KStream.transformValues (apache#8298)
  MINOR: reuse pseudo-topic in FKJoin (apache#8296)
  KAFKA-6145: Pt 2. Include offset sums in subscription (apache#8246)
  KAFKA-9714; Eliminate unused reference to IBP in `TransactionStateManager` (apache#8293)
  KAFKA-9718; Don't log passwords for AlterConfigs in request logs (apache#8294)
  KAFKA-8768: DeleteRecords request/response automated protocol (apache#7957)
  KAFKA-9685: Solve Set concatenation perf issue in AclAuthorizer
  ...
gitlw pushed a commit to linkedin/kafka that referenced this pull request Sep 9, 2021
…ed in apache#8083 (apache#8301)

Reviewers: Colin P. McCabe <cmccabe@apache.org>, Brian Byrne <bbyrne@confluent.io>
@chia7712 chia7712 deleted the hotfix_compile_error_DescribeClientQuotasRequest branch March 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants