Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
ClientQuotaFilterComponent that = (ClientQuotaFilterComponent) o;
return Objects.equals(entityType, match);
return Objects.equals(that.entityType, entityType) && Objects.equals(that.match, match);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@

import java.util.ArrayList;
import java.util.List;
import java.util.Collection;

public class DescribeClientQuotasRequest extends AbstractRequest {
// These values must not change.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@
import static org.apache.kafka.common.message.ListPartitionReassignmentsResponseData.OngoingTopicReassignment;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertThrows;
Expand Down Expand Up @@ -2878,6 +2879,28 @@ public void testDescribeClientQuotas() throws Exception {
}
}

@Test
public void testEqualsOfClientQuotaFilterComponent() {
assertEquals(ClientQuotaFilterComponent.ofDefaultEntity(ClientQuotaEntity.USER),
ClientQuotaFilterComponent.ofDefaultEntity(ClientQuotaEntity.USER));

assertEquals(ClientQuotaFilterComponent.ofEntityType(ClientQuotaEntity.USER),
ClientQuotaFilterComponent.ofEntityType(ClientQuotaEntity.USER));

// match = null is different from match = Empty
assertNotEquals(ClientQuotaFilterComponent.ofDefaultEntity(ClientQuotaEntity.USER),
ClientQuotaFilterComponent.ofEntityType(ClientQuotaEntity.USER));

assertEquals(ClientQuotaFilterComponent.ofEntity(ClientQuotaEntity.USER, "user"),
ClientQuotaFilterComponent.ofEntity(ClientQuotaEntity.USER, "user"));

assertNotEquals(ClientQuotaFilterComponent.ofEntity(ClientQuotaEntity.USER, "user"),
ClientQuotaFilterComponent.ofDefaultEntity(ClientQuotaEntity.USER));

assertNotEquals(ClientQuotaFilterComponent.ofEntity(ClientQuotaEntity.USER, "user"),
ClientQuotaFilterComponent.ofEntityType(ClientQuotaEntity.USER));
}

public void testAlterClientQuotas() throws Exception {
try (AdminClientUnitTestEnv env = mockClientEnv()) {
env.kafkaClient().setNodeApiVersions(NodeApiVersions.create());
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/kafka/server/KafkaApis.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2820,7 +2820,7 @@ class KafkaApis(val requestChannel: RequestChannel,

if (authorize(request, DESCRIBE_CONFIGS, CLUSTER, CLUSTER_NAME)) {
val result = adminManager.describeClientQuotas(
describeClientQuotasRequest.filter).mapValues(_.mapValues(Double.box).asJava).asJava
describeClientQuotasRequest.filter).mapValues(_.mapValues(Double.box).toMap.asJava).toMap.asJava
sendResponseMaybeThrottle(request, requestThrottleMs =>
new DescribeClientQuotasResponse(result, requestThrottleMs))
} else {
Expand Down