KAFKA-9739: 2.3 null child node fix#8419
Merged
bbejeck merged 2 commits intoapache:2.3from Apr 4, 2020
Merged
Conversation
2.4 port of apache#8400 since cherry-picking not possible Reviewers: John Roesler <john@confluent.io>
…sort source nodes so to merge this PR with 2.3 I had to update the expected topology to what was expected on 2.3
Member
Author
|
retest this please |
andrewchoi5
approved these changes
Apr 4, 2020
Member
Author
|
Merged #8419 into 2.3 |
bbejeck
added a commit
that referenced
this pull request
Apr 4, 2020
A port of #8400 for 2.3. The process of sorting source and sink nodes changed in 2.4, so we can't cherry-pick the PR directly as we need to update the expected topology to what it would be in the 2.3 version. Reviewers: John Roesler <john@confluent.io>, Andrew Choi <a24choi@edu.uwaterloo.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A port of #8400 for 2.3. The process of sorting source and sink nodes changed in 2.4, so we can't cherry-pick the PR directly as we need to update the expected topology to what it would be in the 2.3 version.
Committer Checklist (excluded from commit message)