KAFKA-9748: Extend Streams integration tests for EOS beta#8441
KAFKA-9748: Extend Streams integration tests for EOS beta#8441mjsax merged 2 commits intoapache:trunkfrom
Conversation
| produceInitialGlobalTableValues(true); | ||
| } | ||
|
|
||
| private void produceInitialGlobalTableValues(final boolean enableTransactions) throws Exception { |
There was a problem hiding this comment.
We always set it to true -- removing unnecessary code.
| taskId, | ||
| Task.TaskType.ACTIVE, | ||
| EXACTLY_ONCE.equals(streamsConfig.getString(StreamsConfig.PROCESSING_GUARANTEE_CONFIG)), | ||
| StreamThread.eosEnabled(streamsConfig), |
| {StreamsConfig.EXACTLY_ONCE}, | ||
| {StreamsConfig.AT_LEAST_ONCE} | ||
| {StreamsConfig.EXACTLY_ONCE_BETA} | ||
| }); |
There was a problem hiding this comment.
General question: we record the same metric for all three processing modes. Why do you need to parametrize this test? \cc @cadonna
|
|
||
| @Test | ||
| public void shouldRestoreAndProgressWhenTopicWrittenToDuringRestorationWithEosEnabled() throws Exception { | ||
| public void shouldRestoreAndProgressWhenTopicWrittenToDuringRestorationWithEosAlphaEnabled() throws Exception { |
There was a problem hiding this comment.
Could we extract the test portion as a common function?
|
Both Jenkins runs passed. Magic! |
|
Build failed with Seems to be fixed via #8447 Can retest after more reviews. |
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
LGTM. Please feel free after green builds (maybe also run locally multiple times to capture any flakiness regression earlier) and comments addressed.
|
Retest this please. |
|
Java 8 passed. Retest this please. |
|
Java 8 passed. Different test as before. Also run the tests locally multiple times without issues. Merging this. |
3 participants
The original PR was only considering
EosIntegrationTest. However, there are actually a few more integration test with eos-alpha enabled that we missed to update.Call for review @abbccdda @guozhangwang