HOTFIX: exclude ConsumerCoordinator from NPathComplexity check#8447
Merged
rajinisivaram merged 1 commit intoapache:trunkfrom Apr 8, 2020
Conversation
Member
Author
|
ping @guozhangwang the issue is related to 94ef25a. |
Contributor
|
@chia7712 Thanks for the PR, LGTM. Merging this since builds are broken at the moment. |
This was referenced Apr 8, 2020
chia7712
deleted the
exclude_ConsumerCoordinator_from_NPathComplexity_check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to simplify the fix so this PR does not refactor
ConsumerCoordinator#onJoinComplete. By contrast, this PR exclude ConsumerCoordinator from NPathComplexity check directly.Committer Checklist (excluded from commit message)