MINOR: Further reduce runtime for metrics integration tests#8514
Merged
guozhangwang merged 3 commits intoapache:trunkfrom Apr 20, 2020
Merged
Conversation
Contributor
Author
Member
|
Checkstyle error: |
mjsax
reviewed
Apr 19, 2020
| new Properties() | ||
| ), | ||
| STREAM_INPUT_TWO, | ||
| Collections.singleton(new KeyValue<>(1, "A")), |
Member
There was a problem hiding this comment.
Why do we write into STREAM_INPUT_TWO with 3 calls instead of just one call passing in all 3 records at once?
Contributor
Author
There was a problem hiding this comment.
Note we use a mocktime with auto tick WINDOW_SIZE.toMillis(): and each time its milliseconds() is called it would auto-advance, we need the produced records with those advanced timestamps.
mjsax
approved these changes
Apr 19, 2020
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Overall LGTM. Feel free to merge after checkstyle is fixed.
…educe-metrics-integration-runtime
cadonna
reviewed
Apr 20, 2020
| () -> "RocksDB metric bytes.written.total did not increase in " + TIMEOUT + " ms" | ||
| ); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Thank you! I forgot to delete this in my refactoring.
cadonna
approved these changes
Apr 20, 2020
Contributor
Author
|
Merged to trunk. |
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Apr 21, 2020
* apache-github/trunk: MINOR: Fix grammar in error message for InvalidRecordException (apache#8465) KAFKA-9868: Reduce number of transaction log partitions for embed broker (apache#8522) MINOR: Adding github whitelist (apache#8523) MINOR: Upgrade gradle plugins and test libraries for Java 14 support (apache#8519) MINOR: Further reduce runtime for metrics integration tests (apache#8514) MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists (apache#8521) MINOR: Update to Gradle 6.3 (apache#7677) HOTFIX: fix checkstyle error of RocksDBStoreTest and flaky RocksDBTimestampedStoreTest.shouldOpenExistingStoreInRegularMode (apache#8515) MINOR: cleanup RocksDBStore tests (apache#8510) KAFKA-9818: Fix flaky test in RecordCollectorTest (apache#8507) MINOR: reduce impact of trace logging in replica hot path (apache#8468) KAFKA-6145: KIP-441: Add test scenarios to ensure rebalance convergence (apache#8475) KAFKA-9881: Convert integration test to verify measurements from RocksDB to unit test (apache#8501) MINOR: improve test coverage for dynamic LogConfig(s) (apache#7616) MINOR: Switch order of sections on tumbling and hopping windows in streams doc. Tumbling windows are defined as "special case of hopping time windows" - but hopping windows currently only explained later in the docs. (apache#8505) KAFKA-9819: Fix flaky test in StoreChangelogReaderTest (apache#8488)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In both RocksDBMetrics and Metrics integration tests, we do not need to wait for consumer to consume records from output topics since the sensors / metrics are registered upon task creation.
Merged the two test cases of RocksDB with one app that creates two state stores (non-segmented and segmented).
With these two changes, local runtime of these two tests reduced from 2min+ and 3min+ to under a minute.
Committer Checklist (excluded from commit message)