KAFKA-9868: Reduce transaction log partitions for embed broker#8522
Merged
mjsax merged 1 commit intoapache:trunkfrom Apr 21, 2020
Merged
KAFKA-9868: Reduce transaction log partitions for embed broker#8522mjsax merged 1 commit intoapache:trunkfrom
mjsax merged 1 commit intoapache:trunkfrom
Conversation
abbccdda
commented
Apr 20, 2020
| putIfAbsent(brokerConfig, KafkaConfig$.MODULE$.GroupInitialRebalanceDelayMsProp(), 0); | ||
| putIfAbsent(brokerConfig, KafkaConfig$.MODULE$.OffsetsTopicReplicationFactorProp(), (short) 1); | ||
| putIfAbsent(brokerConfig, KafkaConfig$.MODULE$.OffsetsTopicPartitionsProp(), 5); | ||
| putIfAbsent(brokerConfig, KafkaConfig$.MODULE$.TransactionsTopicPartitionsProp(), 5); |
Author
There was a problem hiding this comment.
This is the actual fix, other parts are just side cleanups.
Author
Member
|
Retest this please. |
mjsax
approved these changes
Apr 20, 2020
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
LGTM. Let's see if this helps. If yes, we might want to do a similar thing for all EOS integration tests?
mjsax
reviewed
Apr 20, 2020
| * Creates and starts a Kafka cluster. | ||
| */ | ||
| public void start() throws IOException, InterruptedException { | ||
| public void start() throws IOException { |
Member
There was a problem hiding this comment.
If we would have written throws Exception from the beginning on, this change would not be necessary... (Just to back up my preferred coding stile to only use throws Exception in tests.)
Author
|
Run 350 times on local and no failure. |
Author
|
@mjsax I suppose this should help for all integration tests, as they share |
Author
|
Got 2/3 green, one failed test is due to |
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Apr 21, 2020
* apache-github/trunk: MINOR: Fix grammar in error message for InvalidRecordException (apache#8465) KAFKA-9868: Reduce number of transaction log partitions for embed broker (apache#8522) MINOR: Adding github whitelist (apache#8523) MINOR: Upgrade gradle plugins and test libraries for Java 14 support (apache#8519) MINOR: Further reduce runtime for metrics integration tests (apache#8514) MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists (apache#8521) MINOR: Update to Gradle 6.3 (apache#7677) HOTFIX: fix checkstyle error of RocksDBStoreTest and flaky RocksDBTimestampedStoreTest.shouldOpenExistingStoreInRegularMode (apache#8515) MINOR: cleanup RocksDBStore tests (apache#8510) KAFKA-9818: Fix flaky test in RecordCollectorTest (apache#8507) MINOR: reduce impact of trace logging in replica hot path (apache#8468) KAFKA-6145: KIP-441: Add test scenarios to ensure rebalance convergence (apache#8475) KAFKA-9881: Convert integration test to verify measurements from RocksDB to unit test (apache#8501) MINOR: improve test coverage for dynamic LogConfig(s) (apache#7616) MINOR: Switch order of sections on tumbling and hopping windows in streams doc. Tumbling windows are defined as "special case of hopping time windows" - but hopping windows currently only explained later in the docs. (apache#8505) KAFKA-9819: Fix flaky test in StoreChangelogReaderTest (apache#8488)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the flaky EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore by making the bootstrapping of the test to be less painful with fewer number of partitions of txn log.
The integration test time on local also reduced one second.
Committer Checklist (excluded from commit message)