Skip to content

MINOR: Update raft broken link#8560

Merged
kkonstantine merged 2 commits intoapache:trunkfrom
showuon:fix_broken_link
Apr 28, 2020
Merged

MINOR: Update raft broken link#8560
kkonstantine merged 2 commits intoapache:trunkfrom
showuon:fix_broken_link

Conversation

@showuon
Copy link
Copy Markdown
Member

@showuon showuon commented Apr 27, 2020

Update the raft introduction link. The old link is not accessible now. Update to the official usenix conference link where the raft paper published. It also contains the paper introduction, paper pdf, and presentation video/audio in this link.

old broken link: https://ramcloud.stanford.edu/wiki/download/attachments/11370504/raft.pdf
new link: https://www.usenix.org/conference/atc14/technical-sessions/presentation/ongaro

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

abbccdda
abbccdda approved these changes Apr 27, 2020
View reviewed changes
Copy link
Copy Markdown

@abbccdda abbccdda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kkonstantine
kkonstantine reviewed Apr 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kkonstantine kkonstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion about linking to the pdf directly, but otherwise LGTM

Comment thread docs/design.html Outdated
There are a rich variety of algorithms in this family including ZooKeeper's
<a href="http://web.archive.org/web/20140602093727/http://www.stanford.edu/class/cs347/reading/zab.pdf">Zab</a>,
<a href="https://ramcloud.stanford.edu/wiki/download/attachments/11370504/raft.pdf">Raft</a>,
<a href="https://www.usenix.org/conference/atc14/technical-sessions/presentation/ongaro">Raft</a>,
Copy link
Copy Markdown
Contributor

@kkonstantine kkonstantine Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the spotting the fix.
Minor suggestion, I think it'd be best to link directly to the paper (pdf) instead of the page of the presentation (that indeed includes the paper too).

Here are two options:
https://web.stanford.edu/~ouster/cgi-bin/papers/raft-atc14
or
https://www.usenix.org/system/files/conference/atc14/atc14-paper-ongaro.pdf

Copy link
Copy Markdown
Member Author

@showuon showuon Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @kkonstantine ,
Thanks for the comments. I've updated the link to the pdf link: https://www.usenix.org/system/files/conference/atc14/atc14-paper-ongaro.pdf

Thanks.

@kkonstantine kkonstantine changed the title MINOR: update raft borken link MINOR: Update raft broken link Apr 28, 2020
kkonstantine
kkonstantine approved these changes Apr 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kkonstantine kkonstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @showuon
LGTM!

@kkonstantine kkonstantine merged commit 2bc87de into apache:trunk Apr 28, 2020
@showuon showuon deleted the fix_broken_link branch April 28, 2020 06:29
ijuma added a commit to confluentinc/kafka that referenced this pull request Apr 30, 2020
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into `confluentinc…
31c13ff 
…/master`

* apache-github/trunk: (45 commits)
  MINOR: Fix broken JMX link in docs by adding missing starting double quote (apache#8587)
  KAFKA-9652: Fix throttle metric in RequestChannel and request log due to KIP-219 (apache#8567)
  KAFKA-9922: Update demo instructions in examples README (apache#8559)
  KAFKA-9830: Implement AutoCloseable in ErrorReporter and subclasses (apache#8442)
  KAFKA-9875: Make integration tests more resilient (apache#8578)
  KAFKA-9932: Don't load configs from ZK when the log has already been loaded (apache#8582)
  KAFKA-9925: decorate pseudo-topics with app id (apache#8574)
  KAFKA-9832: fix attempt to commit non-running tasks (apache#8580)
  KAFKA-9127: don't create StreamThreads for global-only topology (apache#8540)
  MINOR: add support for kafka 2.4 and 2.5 to downgrade test
  KAFKA-9176: Retry on getting local stores from KafkaStreams (apache#8568)
  KAFKA-9823: Follow-up, check state for handling commit error response (apache#8548)
  KAFKA-6145: KIP-441: Add TaskAssignor class config (apache#8541)
  MINOR: Fix partition numbering from 0 to P-1 instead of P in docs (apache#8572)
  KAFKA-9921: disable caching on stores configured to retain duplicates (apache#8564)
  Minor: remove redundant check in auto preferred leader election (apache#8566)
  MINOR: Update the link to the Raft paper in docs (apache#8560)
  MINOR: Fix typos in config properties in MM2 test (apache#8561)
  MINOR: Improve producer test BufferPoolTest#testCloseNotifyWaiters. (apache#7982)
  MINOR: document how to escape json parameters to ducktape tests (apache#8546)
  ...
ijuma added a commit to confluentinc/kafka that referenced this pull request Apr 30, 2020
@ijuma
CONFLUENT: Sync from apache/kafka (29 April 2020)
1f84e45 
There was a minor conflict in gradle.properties because the default
Scala version changed upstream to Scala 2.13. I kept the upstream
change.

Related to this, I have updated Jenkinsfile to compile and validate
with Scala 2.12 in a separate stage so that we ensure we maintain
compatibility. Unlike Apache Kafka, we only run the tests with the
default Scala version, which is now 2.13.

* apache-github/trunk: (45 commits)
MINOR: Fix broken JMX link in docs by adding missing starting double
quote (apache#8587)
KAFKA-9652: Fix throttle metric in RequestChannel and request log due
to KIP-219 (apache#8567)
  KAFKA-9922: Update demo instructions in examples README (apache#8559)
KAFKA-9830: Implement AutoCloseable in ErrorReporter and subclasses
(apache#8442)
  KAFKA-9875: Make integration tests more resilient (apache#8578)
KAFKA-9932: Don't load configs from ZK when the log has already been
loaded (apache#8582)
  KAFKA-9925: decorate pseudo-topics with app id (apache#8574)
  KAFKA-9832: fix attempt to commit non-running tasks (apache#8580)
KAFKA-9127: don't create StreamThreads for global-only topology
(apache#8540)
  MINOR: add support for kafka 2.4 and 2.5 to downgrade test
  KAFKA-9176: Retry on getting local stores from KafkaStreams (apache#8568)
KAFKA-9823: Follow-up, check state for handling commit error response
(apache#8548)
  KAFKA-6145: KIP-441: Add TaskAssignor class config (apache#8541)
MINOR: Fix partition numbering from 0 to P-1 instead of P in docs
(apache#8572)
KAFKA-9921: disable caching on stores configured to retain duplicates
(apache#8564)
Minor: remove redundant check in auto preferred leader election
(apache#8566)
  MINOR: Update the link to the Raft paper in docs (apache#8560)
  MINOR: Fix typos in config properties in MM2 test (apache#8561)
MINOR: Improve producer test BufferPoolTest#testCloseNotifyWaiters.
(apache#7982)
MINOR: document how to escape json parameters to ducktape tests
(apache#8546)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbccdda abbccdda abbccdda approved these changes

@kkonstantine kkonstantine kkonstantine approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@showuon @abbccdda @kkonstantine