Skip to content

MINOR: Fix broken JMX link by adding missing starting double quote#8587

Merged
kkonstantine merged 1 commit intoapache:trunkfrom
showuon:fix_jmx_broken_link
Apr 30, 2020
Merged

MINOR: Fix broken JMX link by adding missing starting double quote#8587
kkonstantine merged 1 commit intoapache:trunkfrom
showuon:fix_jmx_broken_link

Conversation

@showuon
Copy link
Copy Markdown
Member

@showuon showuon commented Apr 30, 2020

The href attribute missed the starting double quote, so the hyperlink is interpreted as https://docs.oracle.com/.../agent.html", with a redundant tailing double quote. Add the missing starting double quote back to fix this issue.

image

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@wj1918 wj1918 mentioned this pull request Apr 30, 2020
Closed
kkonstantine
kkonstantine approved these changes Apr 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kkonstantine kkonstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kkonstantine kkonstantine merged commit 417d9b1 into apache:trunk Apr 30, 2020
kkonstantine pushed a commit that referenced this pull request Apr 30, 2020
@showuon @kkonstantine
MINOR: Fix broken JMX link in docs by adding missing starting double …
18eea71 
…quote (#8587)

The href attribute missed the starting double quote, so the hyperlink is interpreted as https://docs.oracle.com/.../agent.html", with a redundant tailing double quote. 

Add the missing starting double quote back to fix this issue.

Reviewers: Konstantine Karantasis <konstantine@confluent.io>
kkonstantine pushed a commit that referenced this pull request Apr 30, 2020
@showuon @kkonstantine
MINOR: Fix broken JMX link in docs by adding missing starting double …
45063c0 
…quote (#8587)

The href attribute missed the starting double quote, so the hyperlink is interpreted as https://docs.oracle.com/.../agent.html", with a redundant tailing double quote. 

Add the missing starting double quote back to fix this issue.

Reviewers: Konstantine Karantasis <konstantine@confluent.io>
kkonstantine pushed a commit that referenced this pull request Apr 30, 2020
@showuon @kkonstantine
MINOR: Fix broken JMX link in docs by adding missing starting double …
ba95a5f 
…quote (#8587)

The href attribute missed the starting double quote, so the hyperlink is interpreted as https://docs.oracle.com/.../agent.html", with a redundant tailing double quote. 

Add the missing starting double quote back to fix this issue.

Reviewers: Konstantine Karantasis <konstantine@confluent.io>
ijuma added a commit to confluentinc/kafka that referenced this pull request Apr 30, 2020
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into `confluentinc…
31c13ff 
…/master`

* apache-github/trunk: (45 commits)
  MINOR: Fix broken JMX link in docs by adding missing starting double quote (apache#8587)
  KAFKA-9652: Fix throttle metric in RequestChannel and request log due to KIP-219 (apache#8567)
  KAFKA-9922: Update demo instructions in examples README (apache#8559)
  KAFKA-9830: Implement AutoCloseable in ErrorReporter and subclasses (apache#8442)
  KAFKA-9875: Make integration tests more resilient (apache#8578)
  KAFKA-9932: Don't load configs from ZK when the log has already been loaded (apache#8582)
  KAFKA-9925: decorate pseudo-topics with app id (apache#8574)
  KAFKA-9832: fix attempt to commit non-running tasks (apache#8580)
  KAFKA-9127: don't create StreamThreads for global-only topology (apache#8540)
  MINOR: add support for kafka 2.4 and 2.5 to downgrade test
  KAFKA-9176: Retry on getting local stores from KafkaStreams (apache#8568)
  KAFKA-9823: Follow-up, check state for handling commit error response (apache#8548)
  KAFKA-6145: KIP-441: Add TaskAssignor class config (apache#8541)
  MINOR: Fix partition numbering from 0 to P-1 instead of P in docs (apache#8572)
  KAFKA-9921: disable caching on stores configured to retain duplicates (apache#8564)
  Minor: remove redundant check in auto preferred leader election (apache#8566)
  MINOR: Update the link to the Raft paper in docs (apache#8560)
  MINOR: Fix typos in config properties in MM2 test (apache#8561)
  MINOR: Improve producer test BufferPoolTest#testCloseNotifyWaiters. (apache#7982)
  MINOR: document how to escape json parameters to ducktape tests (apache#8546)
  ...
ijuma added a commit to confluentinc/kafka that referenced this pull request Apr 30, 2020
@ijuma
CONFLUENT: Sync from apache/kafka (29 April 2020)
1f84e45 
There was a minor conflict in gradle.properties because the default
Scala version changed upstream to Scala 2.13. I kept the upstream
change.

Related to this, I have updated Jenkinsfile to compile and validate
with Scala 2.12 in a separate stage so that we ensure we maintain
compatibility. Unlike Apache Kafka, we only run the tests with the
default Scala version, which is now 2.13.

* apache-github/trunk: (45 commits)
MINOR: Fix broken JMX link in docs by adding missing starting double
quote (apache#8587)
KAFKA-9652: Fix throttle metric in RequestChannel and request log due
to KIP-219 (apache#8567)
  KAFKA-9922: Update demo instructions in examples README (apache#8559)
KAFKA-9830: Implement AutoCloseable in ErrorReporter and subclasses
(apache#8442)
  KAFKA-9875: Make integration tests more resilient (apache#8578)
KAFKA-9932: Don't load configs from ZK when the log has already been
loaded (apache#8582)
  KAFKA-9925: decorate pseudo-topics with app id (apache#8574)
  KAFKA-9832: fix attempt to commit non-running tasks (apache#8580)
KAFKA-9127: don't create StreamThreads for global-only topology
(apache#8540)
  MINOR: add support for kafka 2.4 and 2.5 to downgrade test
  KAFKA-9176: Retry on getting local stores from KafkaStreams (apache#8568)
KAFKA-9823: Follow-up, check state for handling commit error response
(apache#8548)
  KAFKA-6145: KIP-441: Add TaskAssignor class config (apache#8541)
MINOR: Fix partition numbering from 0 to P-1 instead of P in docs
(apache#8572)
KAFKA-9921: disable caching on stores configured to retain duplicates
(apache#8564)
Minor: remove redundant check in auto preferred leader election
(apache#8566)
  MINOR: Update the link to the Raft paper in docs (apache#8560)
  MINOR: Fix typos in config properties in MM2 test (apache#8561)
MINOR: Improve producer test BufferPoolTest#testCloseNotifyWaiters.
(apache#7982)
MINOR: document how to escape json parameters to ducktape tests
(apache#8546)
  ...
@showuon showuon deleted the fix_jmx_broken_link branch April 30, 2020 04:02
qq619618919 pushed a commit to qq619618919/kafka that referenced this pull request May 12, 2020
@showuon @qq619618919
MINOR: Fix broken JMX link in docs by adding missing starting double …
7daa997 
…quote (apache#8587)

The href attribute missed the starting double quote, so the hyperlink is interpreted as https://docs.oracle.com/.../agent.html", with a redundant tailing double quote. 

Add the missing starting double quote back to fix this issue.

Reviewers: Konstantine Karantasis <konstantine@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkonstantine kkonstantine kkonstantine approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@showuon @kkonstantine