KAFKA-10052: Harden assertion of topic settings in Connect integration tests#8735
Merged
kkonstantine merged 2 commits intoapache:trunkfrom May 28, 2020
Merged
KAFKA-10052: Harden assertion of topic settings in Connect integration tests#8735kkonstantine merged 2 commits intoapache:trunkfrom
kkonstantine merged 2 commits intoapache:trunkfrom
Conversation
Contributor
Author
|
ok to test |
rhauch
approved these changes
May 28, 2020
Contributor
rhauch
left a comment
rhauch
left a comment
There was a problem hiding this comment.
Thanks, @kkonstantine! LGTM, pending a green build.
Contributor
|
The test failures appear to be unrelated to Connect and are known to be flaky. |
kkonstantine
commented
May 28, 2020
Contributor
Author
kkonstantine
left a comment
kkonstantine
left a comment
There was a problem hiding this comment.
Thanks @rhauch
Indeed, one green build and no Connect IT failures. I agree that probably it's worth merging. We can return to the tests if we notice that this PR didn't fix flakiness.
Cheers!
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
May 30, 2020
* 'trunk' of github.com:apache/kafka: (36 commits) Remove redundant `containsKey` call in KafkaProducer (apache#8761) KAFKA-9494; Include additional metadata information in DescribeConfig response (KIP-569) (apache#8723) KAFKA-10061; Fix flaky `ReassignPartitionsIntegrationTest.testCancellation` (apache#8749) KAFKA-9130; KIP-518 Allow listing consumer groups per state (apache#8238) KAFKA-9501: convert between active and standby without closing stores (apache#8248) KAFKA-10056; Ensure consumer metadata contains new topics on subscription change (apache#8739) MINOR: Log the reason for coordinator discovery failure (apache#8747) KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException (apache#8705) MINOR: remove unnecessary timeout for admin request (apache#8738) MINOR: Relax Percentiles test (apache#8748) MINOR: regression test for task assignor config (apache#8743) MINOR: Update documentation.html to refer to 2.6 (apache#8745) MINOR: Update documentation.html to refer to 2.5 (apache#8744) KAFKA-9673: Filter and Conditional SMTs (apache#8699) KAFKA-9971: Error Reporting in Sink Connectors (KIP-610) (apache#8720) KAFKA-10052: Harden assertion of topic settings in Connect integration tests (apache#8735) MINOR: Slight MetadataCache tweaks to avoid unnecessary work (apache#8728) KAFKA-9802; Increase transaction timeout in system tests to reduce flakiness (apache#8736) KAFKA-10050: kafka_log4j_appender.py fixed for JDK11 (apache#8731) KAFKA-9146: Add option to force delete active members in StreamsResetter (apache#8589) ... # Conflicts: # core/src/main/scala/kafka/log/Log.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recently added assertion in Connect integration tests uses
consumer#partitionsForto verify that a topic was created with the expected number of partitions and replicas. However, probably because of metadata propagation delays, this call doesn't always return a validPartitionInfofor the topic that has just been created and the test is terminated with a NPE.This commit changes the assertion to perform retries in order to verify the topic settings and uses the admin client instead.
Tests have been adjusted to use the new assertion.
Committer Checklist (excluded from commit message)