MINOR: Log the reason for coordinator discovery failure#8747
Merged
vvcephei merged 1 commit intoapache:trunkfrom May 29, 2020
vvcephei:minor-log-coordinator-exception
Merged
MINOR: Log the reason for coordinator discovery failure#8747vvcephei merged 1 commit intoapache:trunkfrom vvcephei:minor-log-coordinator-exception
vvcephei merged 1 commit intoapache:trunkfrom
vvcephei:minor-log-coordinator-exception
Conversation
Contributor
Author
|
Hey @hachikuji , Can you take a quick look at this? You were the last to edit this block. I was debugging a system test failure, and I see a situation where the broker appears completely healthy, but the Streams consumer just prints I didn't see any way to get more information on what exactly the failure was, so I'd like to add the actual causing exception to the log line. Since it's a debug log, this seems ok, but I'm interested in feedback. Thanks! |
Contributor
Author
|
The java 14 test failure is unrelated and fixed in #8748 |
abbccdda
approved these changes
May 28, 2020
Contributor
Author
|
Java 11 build timed out. |
Contributor
Author
|
Thanks for the review, @abbccdda ! |
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
May 30, 2020
* 'trunk' of github.com:apache/kafka: (36 commits) Remove redundant `containsKey` call in KafkaProducer (apache#8761) KAFKA-9494; Include additional metadata information in DescribeConfig response (KIP-569) (apache#8723) KAFKA-10061; Fix flaky `ReassignPartitionsIntegrationTest.testCancellation` (apache#8749) KAFKA-9130; KIP-518 Allow listing consumer groups per state (apache#8238) KAFKA-9501: convert between active and standby without closing stores (apache#8248) KAFKA-10056; Ensure consumer metadata contains new topics on subscription change (apache#8739) MINOR: Log the reason for coordinator discovery failure (apache#8747) KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException (apache#8705) MINOR: remove unnecessary timeout for admin request (apache#8738) MINOR: Relax Percentiles test (apache#8748) MINOR: regression test for task assignor config (apache#8743) MINOR: Update documentation.html to refer to 2.6 (apache#8745) MINOR: Update documentation.html to refer to 2.5 (apache#8744) KAFKA-9673: Filter and Conditional SMTs (apache#8699) KAFKA-9971: Error Reporting in Sink Connectors (KIP-610) (apache#8720) KAFKA-10052: Harden assertion of topic settings in Connect integration tests (apache#8735) MINOR: Slight MetadataCache tweaks to avoid unnecessary work (apache#8728) KAFKA-9802; Increase transaction timeout in system tests to reduce flakiness (apache#8736) KAFKA-10050: kafka_log4j_appender.py fixed for JDK11 (apache#8731) KAFKA-9146: Add option to force delete active members in StreamsResetter (apache#8589) ... # Conflicts: # core/src/main/scala/kafka/log/Log.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the exception in the case of logging the "Coordinator discovery failed" message.
Committer Checklist (excluded from commit message)