KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used#8737
Merged
cmccabe merged 3 commits intoapache:trunkfrom Jun 2, 2020
Conversation
…ts when --bootstrap-server is used - Fixed command line arg checking - Added unit test cases
vinothchandar
commented
May 28, 2020
cmccabe
reviewed
May 28, 2020
cmccabe
reviewed
May 28, 2020
cmccabe
reviewed
May 28, 2020
cmccabe
reviewed
May 28, 2020
- Avoid unnecessary RPC to server, if effective topic list is empty - Efficient use of AdminClient#listPartitionReassignments() - Fix if check style
Member
Author
|
https://issues.apache.org/jira/browse/KAFKA-10071 Opened this to track the follow ups.. @cmccabe let me know if you have further comments on the PR. |
cmccabe
reviewed
May 30, 2020
| topicDesc.printDescription() | ||
| ensureTopicExists(topics, opts.topic, !opts.ifExists) | ||
|
|
||
| if (topics.nonEmpty) { |
Contributor
There was a problem hiding this comment.
It's not necessary to check this. AdminClient handles being passed empty lists or sets of topics.
Member
Author
There was a problem hiding this comment.
val liveBrokers = adminClient.describeCluster().nodes().get().asScala.map(_.id())
This line still makes an RPC call.
cmccabe
reviewed
May 30, 2020
Contributor
|
Thanks for working on this, @vinothchandar. I think it's almost ready to go. I left two comments. |
vinothchandar
commented
May 30, 2020
Member
Author
vinothchandar
left a comment
vinothchandar
left a comment
There was a problem hiding this comment.
I have removed the topics empty check from places, where no extra RPC call would be made. And also changed the tests to not catch-fail, given Kafka is not using the pattern widely.. (personally, I still see value in failing the test explicitly.. Thats why stuff like [assertDoesNotThrow](http://junit.org/junit5/docs/5.3.0/api/org/junit/jupiter/api/Assertions.html#assertDoesNotThrow(org.junit.ju…) was introduced. or alternatively we could have expected a none exception)
Hope this addresses all the comments..
Contributor
|
LGTM |
Contributor
|
Thanks @vinothchandar ! |
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Jun 3, 2020
* apache-github/2.6: (32 commits) KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests (apache#8786) KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used (apache#8737) KAFKA-9320: Enable TLSv1.3 by default (KIP-573) (apache#8695) KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment (apache#8777) MINOR: Remove unused variable to fix spotBugs failure (apache#8779) MINOR: ChangelogReader should poll for duration 0 for standby restore (apache#8773) KAFKA-10030: Allow fetching a key from a single partition (apache#8706) Kafka-10064 Add documentation for KIP-571 (apache#8760) MINOR: Code cleanup and assertion message fixes in Connect integration tests (apache#8750) KAFKA-9987: optimize sticky assignment algorithm for same-subscription case (apache#8668) KAFKA-9392; Clarify deleteAcls javadoc and add test for create/delete timing (apache#7956) KAFKA-10074: Improve performance of `matchingAcls` (apache#8769) KAFKA-9494; Include additional metadata information in DescribeConfig response (KIP-569) (apache#8723) KAFKA-10056; Ensure consumer metadata contains new topics on subscription change (apache#8739) KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException (apache#8705) KAFKA-10061; Fix flaky `ReassignPartitionsIntegrationTest.testCancellation` (apache#8749) KAFKA-9130; KIP-518 Allow listing consumer groups per state (apache#8238) KAFKA-9501: convert between active and standby without closing stores (apache#8248) MINOR: Relax Percentiles test (apache#8748) MINOR: regression test for task assignor config (apache#8743) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)