Skip to content

KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests#8786

Merged
guozhangwang merged 2 commits intoapache:trunkfrom
ableegoldman:10083-fix-testReassignmentWithRandomSubscriptionsAndChanges
Jun 3, 2020
Merged

KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests#8786
guozhangwang merged 2 commits intoapache:trunkfrom
ableegoldman:10083-fix-testReassignmentWithRandomSubscriptionsAndChanges

Conversation

@ableegoldman
Copy link
Copy Markdown
Member

Minimum fix needed to stop this test failing and unblock others

@showuon
Copy link
Copy Markdown
Member

showuon commented Jun 3, 2020

LGTM. Thanks @ableegoldman

@guozhangwang
Copy link
Copy Markdown
Contributor

test this please

@guozhangwang
Copy link
Copy Markdown
Contributor

LGTM. Will wait for jenkins to pass.

@ableegoldman
Copy link
Copy Markdown
Member Author

Will wait for jenkins to pass.

At least we learned from all this 😄

@ableegoldman
Copy link
Copy Markdown
Member Author

Java14. passed
Java 11 failed with unrelated PlaintextProducerSendTest.testNonBlockingProducer
Java 8 failed with four unrelated:
CustomQuotaCallbackTest.testCustomQuotaCallback
PlaintextConsumerTest.testLowMaxFetchSizeForRequestAndPartition
KTableKTableForeignKeyInnerJoinMultiIntegrationTest.shouldInnerJoinMultiPartitionQueryable
OptimizedKTableIntegrationTest.shouldApplyUpdatesToStandbyStore

@guozhangwang guozhangwang merged commit 35a0692 into apache:trunk Jun 3, 2020
guozhangwang pushed a commit that referenced this pull request Jun 3, 2020
…nges tests (#8786)

Minimum fix needed to stop this test failing and unblock others

Co-authored-by: Luke Chen <showuon@gmail.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>
guozhangwang pushed a commit that referenced this pull request Jun 3, 2020
…nges tests (#8786)

Minimum fix needed to stop this test failing and unblock others

Co-authored-by: Luke Chen <showuon@gmail.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>
ijuma added a commit to confluentinc/kafka that referenced this pull request Jun 3, 2020
* apache-github/2.6: (32 commits)
  KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests (apache#8786)
  KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used (apache#8737)
  KAFKA-9320: Enable TLSv1.3 by default (KIP-573) (apache#8695)
  KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment (apache#8777)
  MINOR: Remove unused variable to fix spotBugs failure (apache#8779)
  MINOR: ChangelogReader should poll for duration 0 for standby restore (apache#8773)
  KAFKA-10030: Allow fetching a key from a single partition (apache#8706)
  Kafka-10064 Add documentation for KIP-571 (apache#8760)
  MINOR: Code cleanup and assertion message fixes in Connect integration tests (apache#8750)
  KAFKA-9987: optimize sticky assignment algorithm for same-subscription case (apache#8668)
  KAFKA-9392; Clarify deleteAcls javadoc and add test for create/delete timing (apache#7956)
  KAFKA-10074: Improve performance of `matchingAcls` (apache#8769)
  KAFKA-9494; Include additional metadata information in DescribeConfig response (KIP-569) (apache#8723)
  KAFKA-10056; Ensure consumer metadata contains new topics on subscription change (apache#8739)
  KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException (apache#8705)
  KAFKA-10061; Fix flaky `ReassignPartitionsIntegrationTest.testCancellation` (apache#8749)
  KAFKA-9130; KIP-518 Allow listing consumer groups per state (apache#8238)
  KAFKA-9501: convert between active and standby without closing stores (apache#8248)
  MINOR: Relax Percentiles test (apache#8748)
  MINOR: regression test for task assignor config (apache#8743)
  ...
guozhangwang pushed a commit that referenced this pull request Jun 3, 2020
…nges tests (#8786)

Minimum fix needed to stop this test failing and unblock others

Co-authored-by: Luke Chen <showuon@gmail.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>
@guozhangwang
Copy link
Copy Markdown
Contributor

Cherry-picked back to 2.4

ijuma added a commit that referenced this pull request Jun 4, 2020
…use_all_dns_ips-as-default

* apache-github/trunk:
  KAFKA-9788; Use distinct names for transaction and group load time sensors (#8784)
  KAFKA-9514; The protocol generator generated useless condition when a field is made nullable and flexible version is used (#8793)
  MINOR: Update to Gradle 6.5 and tweak build jvm config (#8751)
  MINOR: Upgrade spotbugs and spotbugsPlugin (#8790)
  KAFKA-10089 The stale ssl engine factory is not closed after reconfigure (#8792)
  KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends (#8782)
  KAFKA-10084: Fix EosTestDriver end offset (#8785)
  KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests (#8786)
@ableegoldman ableegoldman deleted the 10083-fix-testReassignmentWithRandomSubscriptionsAndChanges branch June 26, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants