MINOR: Upgrade spotbugs and spotbugsPlugin#8790
Merged
ijuma merged 2 commits intoapache:trunkfrom Jun 3, 2020
Merged
Conversation
Member
Author
|
@ijuma , could you review this small PR to upgrade spotbugsPlugin? Thanks. |
Member
|
ok to test |
ijuma
approved these changes
Jun 3, 2020
Member
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Thanks, nice investigation. LGTM.
Member
|
ok to test |
Member
|
I bumped spotbugs to 4.0.3 while we're at it. |
Member
|
ok to test |
Member
|
retest this please |
Member
Author
|
Thanks. |
showuon
changed the title
Member
|
ok to test |
Member
|
retest this please |
Member
|
One job failed for unrelated reasons. |
ijuma
pushed a commit
that referenced
this pull request
Jun 3, 2020
Upgrade spotbugsPlugin to have clear output indicating where the error is. When investigating KAFKA-10081, I found the error output of spotbugs is very poor. It doesn't even tell you where the error is and how many errors found, it will take a lot of time for the developers to find out where the error is, and then fix it.  https://builds.apache.org/blue/organizations/jenkins/kafka-trunk-jdk8/detail/kafka-trunk-jdk8/4596/pipeline/ Then, I found out there's a bug in spotbugsPlugin in V4.0.x, and got fixed in V4.2.x spotbugs/spotbugs-gradle-plugin#210 So, after upgrading to V4.2.x (I followed to the latest version V4.2.4), the output is like this:  So you know there's 1 error and you can also open the report file to find out the error. Upgraded to the latest bug fix release of spotbugs (4.0.3) while at it. Reviewers: Ismael Juma <ismael@juma.me.uk>
ijuma
added a commit
that referenced
this pull request
Jun 4, 2020
…use_all_dns_ips-as-default * apache-github/trunk: KAFKA-9788; Use distinct names for transaction and group load time sensors (#8784) KAFKA-9514; The protocol generator generated useless condition when a field is made nullable and flexible version is used (#8793) MINOR: Update to Gradle 6.5 and tweak build jvm config (#8751) MINOR: Upgrade spotbugs and spotbugsPlugin (#8790) KAFKA-10089 The stale ssl engine factory is not closed after reconfigure (#8792) KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends (#8782) KAFKA-10084: Fix EosTestDriver end offset (#8785) KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests (#8786)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade spotbugsPlugin to have clear error output to indicate where the error is.
When investigating KAFKA-10081, I found the error output of spotbugs is very poor. It doesn't even tell you where the error is and how many errors found, it will take a lot of time for the developers to find out where the error is, and then fix it.
https://builds.apache.org/blue/organizations/jenkins/kafka-trunk-jdk8/detail/kafka-trunk-jdk8/4596/pipeline/
Then, I found out there's a bug in spotbugsPlugin in V4.0.x, and got fixed in V4.2.x
spotbugs/spotbugs-gradle-plugin#210
So, after upgrading to V4.2.x (I followed to the latest version V4.2.4), the output is like this:
So you know there's 1 error and you can also open the report file to find out the error.
I think this is very important to save the developer's time to fix the spotBug issues while developing. Thanks.
Committer Checklist (excluded from commit message)