Skip to content

KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest #8883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 2 commits into from
Jun 18, 2020
+5 −12
Merged

KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest #8883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a530dad
use TestUtil, first wait for RUNNING
ableegoldman Jun 16, 2020
46a50f3
checkstyle
ableegoldman Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions ...ams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@
import java.io.File;
import java.io.IOException;
import java.time.Duration;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.Properties;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;

import static java.util.Arrays.asList;
import static org.apache.kafka.streams.integration.utils.IntegrationTestUtils.safeUniqueTestName;
import static org.apache.kafka.test.TestUtils.waitForCondition;
import static org.apache.kafka.streams.integration.utils.IntegrationTestUtils.startApplicationAndWaitUntilRunning;
import static org.junit.Assert.assertTrue;

/**
Expand All @@ -63,7 +63,7 @@ public class StandbyTaskEOSIntegrationTest {

@Parameterized.Parameters(name = "{0}")
public static Collection<String[]> data() {
return Arrays.asList(new String[][] {
return asList(new String[][] {
{StreamsConfig.EXACTLY_ONCE},
{StreamsConfig.EXACTLY_ONCE_BETA}
});
Expand Down Expand Up @@ -91,7 +91,7 @@ public void createTopics() throws Exception {
}

@Test
public void surviveWithOneTaskAsStandby() throws Exception {
public void shouldSurviveWithOneTaskAsStandby() throws Exception {
IntegrationTestUtils.produceKeyValuesSynchronouslyWithTimestamp(
inputTopic,
Collections.singletonList(
Expand All @@ -111,18 +111,11 @@ public void surviveWithOneTaskAsStandby() throws Exception {
final KafkaStreams streamInstanceOne = buildStreamWithDirtyStateDir(stateDirPath + "/" + appId + "-1/", instanceLatch);
final KafkaStreams streamInstanceTwo = buildStreamWithDirtyStateDir(stateDirPath + "/" + appId + "-2/", instanceLatch);
) {
streamInstanceOne.start();

streamInstanceTwo.start();
startApplicationAndWaitUntilRunning(asList(streamInstanceOne, streamInstanceTwo), Duration.ofSeconds(60));

// Wait for the record to be processed
assertTrue(instanceLatch.await(15, TimeUnit.SECONDS));

waitForCondition(() -> streamInstanceOne.state().equals(KafkaStreams.State.RUNNING),
"Stream instance one should be up and running by now");
waitForCondition(() -> streamInstanceTwo.state().equals(KafkaStreams.State.RUNNING),
"Stream instance two should be up and running by now");

streamInstanceOne.close(Duration.ZERO);
streamInstanceTwo.close(Duration.ZERO);

Expand Down