KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest#8883
Merged
guozhangwang merged 2 commits intoapache:trunkfrom Jun 18, 2020
Merged
Conversation
Member
|
Retest this please. |
mjsax
approved these changes
Jun 16, 2020
Member
|
Retest this please. |
1 similar comment
Member
|
Retest this please. |
Member
|
Checkstyle error: |
ableegoldman
force-pushed
the
HOTFIX-fix-flaky-StandbyTaskEOSIntegrationTest
branch
from
767ae11 to
46a50f3
Compare
Member
|
Retest this please. |
1 similar comment
Member
|
Retest this please. |
Member
Author
|
Failed with unrelated flaky |
Member
|
Retest this please |
Member
Author
|
@mjsax can this merged? One failure in one build:
|
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
Jun 21, 2020
* 'trunk' of github.com:apache/kafka: KAFKA-10168: fix StreamsConfig parameter name variable (apache#8865) MINOR: code cleanup for inconsistent naming (apache#8871) KAFKA-10138: Prefer --bootstrap-server for reassign_partitions command in ducktape tests (apache#8898) KAFKA-10185: Restoration info logging (apache#8896) KAFKA-9891: add integration tests for EOS and StandbyTask (apache#8890) MINOR: Reduce build time by gating test coverage plugins behind a flag (apache#8899) KAFKA-10141; Add more detail to log segment delete messages (apache#8850) KAFKA-10113; Specify fetch offsets correctly in `LogTruncationException` (apache#8822) KAFKA-10167: use the admin client to read end-offset (apache#8876) MINOR: Upgrade ducktape to 0.7.8 (apache#8879) KAFKA-10123; Fix incorrect value for AWAIT_RESET#hasPosition (apache#8841) KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest (apache#8883) MINOR: clean up unused checkstyle suppressions for Streams (apache#8861) MINOR: reuse toConfigObject(Map) to generate Config (apache#8889) MINOR: Upgrade jetty to 9.4.27.v20200227 and jersey to 2.31 (apache#8859) MINOR: Fix flaky HighAvailabilityTaskAssignorIntegrationTest (apache#8884) KAFKA-10147 MockAdminClient#describeConfigs(Collection<ConfigResource>) is unable to handle broker resource (apache#8853) KAFKA-10165: Remove Percentiles from e2e metrics (apache#8882) # Conflicts: # core/src/main/scala/kafka/log/Log.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We seem to typically fail on waiting for the first record to be processed, which we only give 15s. 15s to process a single record is reasonable, but we don't wait for the instances to reach the RUNNIG state until after we wait for the record to be processed.
We should first make sure the instance reaches running (for which a 60s timeout seems to be the common case in other integration tests), and then wait on the record to be processed.