KAFKA-10147 MockAdminClient#describeConfigs(Collection<ConfigResource…#8853
KAFKA-10147 MockAdminClient#describeConfigs(Collection<ConfigResource…#8853rhauch merged 1 commit intoapache:trunkfrom
Conversation
|
@rhauch Could you take a look? |
|
Yeah, will look more closely in a few min. If this breaks tests, can you please change the KAFKA issue priority to blocker and fill in the affected versions? |
There was a problem hiding this comment.
Maybe just deprecate public method instead of removing it
There was a problem hiding this comment.
this method has default implementation (see https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/Admin.java#L340) which calls the variety describeConfigs(Collection<ConfigResource>, DescribeConfigsOptions) so it is ok to remove the new implementation.
|
retest this please |
1 similar comment
|
retest this please |
|
the failed build is traced by #8857 |
…>) is unable to handle broker resource
|
retest this please |
|
retest this please |
|
other flaky pass on my local :( |
|
retest this please |
1 similar comment
|
retest this please |
|
@rhauch is this ready to be merged? |
| else return new Config(topicMetadata.configs.entrySet().stream() | ||
| .map(entry -> new ConfigEntry(entry.getKey(), entry.getValue())) | ||
| .collect(Collectors.toList())); |
There was a problem hiding this comment.
nit: I think that we can use toConfigObject(topicMetadata.configs) here.
There was a problem hiding this comment.
It has been merged when I notice your comment. Let me address it in another PR :)
…>) is unable to handle broker resource (#8853) Author: Chia-Ping Tsai <chia7712@gmail.com> Reviewers: Boyang Chen <boyang@confluent.io>, Randall Hauch <rhauch@gmail.com>
* 'trunk' of github.com:apache/kafka: KAFKA-10168: fix StreamsConfig parameter name variable (apache#8865) MINOR: code cleanup for inconsistent naming (apache#8871) KAFKA-10138: Prefer --bootstrap-server for reassign_partitions command in ducktape tests (apache#8898) KAFKA-10185: Restoration info logging (apache#8896) KAFKA-9891: add integration tests for EOS and StandbyTask (apache#8890) MINOR: Reduce build time by gating test coverage plugins behind a flag (apache#8899) KAFKA-10141; Add more detail to log segment delete messages (apache#8850) KAFKA-10113; Specify fetch offsets correctly in `LogTruncationException` (apache#8822) KAFKA-10167: use the admin client to read end-offset (apache#8876) MINOR: Upgrade ducktape to 0.7.8 (apache#8879) KAFKA-10123; Fix incorrect value for AWAIT_RESET#hasPosition (apache#8841) KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest (apache#8883) MINOR: clean up unused checkstyle suppressions for Streams (apache#8861) MINOR: reuse toConfigObject(Map) to generate Config (apache#8889) MINOR: Upgrade jetty to 9.4.27.v20200227 and jersey to 2.31 (apache#8859) MINOR: Fix flaky HighAvailabilityTaskAssignorIntegrationTest (apache#8884) KAFKA-10147 MockAdminClient#describeConfigs(Collection<ConfigResource>) is unable to handle broker resource (apache#8853) KAFKA-10165: Remove Percentiles from e2e metrics (apache#8882) # Conflicts: # core/src/main/scala/kafka/log/Log.scala
6 participants
MockAdminClient#describeConfigs(Collection<ConfigResource>)has new implementation introduced by 48b56e5. It is unable to handle broker resource soReassignPartitionsUnitTest#testModifyBrokerThrottlesthrows NPE.https://issues.apache.org/jira/browse/KAFKA-10147
Committer Checklist (excluded from commit message)