MINOR: clean up unused checkstyle suppressions for Streams#8861
Merged
mjsax merged 4 commits intoapache:trunkfrom Jun 18, 2020
Merged
MINOR: clean up unused checkstyle suppressions for Streams#8861mjsax merged 4 commits intoapache:trunkfrom
mjsax merged 4 commits intoapache:trunkfrom
Conversation
Member
Author
|
Non-urgent, but some nice cleanup after I noticed how many suppressions aren't necessary anymore @vvcephei @mjsax @guozhangwang |
ableegoldman
force-pushed
the
MINOR-clean-up-checkstyle-suppressions
branch
from
25db463 to
fd0e3a2
Compare
Member
|
As |
Member
|
Retest this please. |
ableegoldman
force-pushed
the
MINOR-clean-up-checkstyle-suppressions
branch
from
fd0e3a2 to
e7fc4f2
Compare
Member
Author
|
Rebased on trunk and removed the TaskManager MethodLength suppression as well (yay 🥳 ), can you kick off tests again @mjsax ? |
Contributor
|
Test this please |
Contributor
|
Retest this please |
Contributor
|
Ok to test |
Contributor
|
Retest this please |
1 similar comment
Contributor
|
Retest this please |
Member
|
Java 11: Java 14: Java 8: |
Member
Author
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
Jun 21, 2020
* 'trunk' of github.com:apache/kafka: KAFKA-10168: fix StreamsConfig parameter name variable (apache#8865) MINOR: code cleanup for inconsistent naming (apache#8871) KAFKA-10138: Prefer --bootstrap-server for reassign_partitions command in ducktape tests (apache#8898) KAFKA-10185: Restoration info logging (apache#8896) KAFKA-9891: add integration tests for EOS and StandbyTask (apache#8890) MINOR: Reduce build time by gating test coverage plugins behind a flag (apache#8899) KAFKA-10141; Add more detail to log segment delete messages (apache#8850) KAFKA-10113; Specify fetch offsets correctly in `LogTruncationException` (apache#8822) KAFKA-10167: use the admin client to read end-offset (apache#8876) MINOR: Upgrade ducktape to 0.7.8 (apache#8879) KAFKA-10123; Fix incorrect value for AWAIT_RESET#hasPosition (apache#8841) KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest (apache#8883) MINOR: clean up unused checkstyle suppressions for Streams (apache#8861) MINOR: reuse toConfigObject(Map) to generate Config (apache#8889) MINOR: Upgrade jetty to 9.4.27.v20200227 and jersey to 2.31 (apache#8859) MINOR: Fix flaky HighAvailabilityTaskAssignorIntegrationTest (apache#8884) KAFKA-10147 MockAdminClient#describeConfigs(Collection<ConfigResource>) is unable to handle broker resource (apache#8853) KAFKA-10165: Remove Percentiles from e2e metrics (apache#8882) # Conflicts: # core/src/main/scala/kafka/log/Log.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out there are a number of checkstyle suppressions that aren't being actively used. Did a quick scan by removing everything and running checkstyle, then left in only those that produced an error.
Should be able to further remove some TaskManager suppressions once pull/8856 is merged