Skip to content

MINOR: Fix flaky HighAvailabilityTaskAssignorIntegrationTest#8884

Merged
vvcephei merged 2 commits intoapache:trunkfrom
vvcephei:minor-fix-flaky-high-availability-task-assignor-integration-test
Jun 17, 2020
Merged

MINOR: Fix flaky HighAvailabilityTaskAssignorIntegrationTest#8884
vvcephei merged 2 commits intoapache:trunkfrom
vvcephei:minor-fix-flaky-high-availability-task-assignor-integration-test

Conversation

@vvcephei
Copy link
Copy Markdown
Contributor

@vvcephei vvcephei commented Jun 16, 2020

Reduce test data set from 1000 records to 500.
Some recent test failures indicate that the Jenkins runners aren't
able to process all 1000 records in two minutes.

Also add sanity check that all the test data are readable from the
input topic.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@vvcephei
Copy link
Copy Markdown
Contributor Author

vvcephei commented Jun 16, 2020

Hey @ableegoldman or @cadonna , do you have a chance to look at this?

Some Jenkins builds have failed like this:

java.lang.AssertionError: Condition not met within timeout 120000. Input records haven't all been written to the changelog: 775
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:26)
	at org.apache.kafka.test.TestUtils.lambda$waitForCondition$6(TestUtils.java:401)
	at org.apache.kafka.test.TestUtils.retryOnExceptionWithTimeout(TestUtils.java:449)
	at org.apache.kafka.test.TestUtils.retryOnExceptionWithTimeout(TestUtils.java:417)
	at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:398)
	at org.apache.kafka.streams.integration.HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasks(HighAvailabilityTaskAssignorIntegrationTest.java:163)
	at org.apache.kafka.streams.integration.HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores(HighAvailabilityTaskAssignorIntegrationTest.java:91)

ableegoldman
ableegoldman approved these changes Jun 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM

@vvcephei
Copy link
Copy Markdown
Contributor Author

vvcephei commented Jun 17, 2020

Looks like this unrelated test is consistently broken:
kafka.admin.ReassignPartitionsUnitTest.testModifyBrokerThrottles

@vvcephei vvcephei merged commit 0c2dfcf into apache:trunk Jun 17, 2020
vvcephei added a commit that referenced this pull request Jun 17, 2020
@vvcephei
MINOR: Fix flaky HighAvailabilityTaskAssignorIntegrationTest (#8884)
f9bda44 
Reduce test data set from 1000 records to 500.
Some recent test failures indicate that the Jenkins runners aren't
able to process all 1000 records in two minutes.

Also add sanity check that all the test data are readable from the
input topic.

Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>
@vvcephei
Copy link
Copy Markdown
Contributor Author

vvcephei commented Jun 17, 2020

Cherry-picked to 2.6

@vvcephei vvcephei deleted the minor-fix-flaky-high-availability-task-assignor-integration-test branch June 17, 2020 15:17
Kvicii pushed a commit to Kvicii/kafka that referenced this pull request Jun 21, 2020
Merge branch 'trunk' of github.com:apache/kafka into trunk-read
137d186 
* 'trunk' of github.com:apache/kafka:
  KAFKA-10168: fix StreamsConfig parameter name variable (apache#8865)
  MINOR: code cleanup for inconsistent naming (apache#8871)
  KAFKA-10138: Prefer --bootstrap-server for reassign_partitions command in ducktape tests (apache#8898)
  KAFKA-10185: Restoration info logging (apache#8896)
  KAFKA-9891: add integration tests for EOS and StandbyTask (apache#8890)
  MINOR: Reduce build time by gating test coverage plugins behind a flag (apache#8899)
  KAFKA-10141; Add more detail to log segment delete messages (apache#8850)
  KAFKA-10113; Specify fetch offsets correctly in `LogTruncationException` (apache#8822)
  KAFKA-10167: use the admin client to read end-offset (apache#8876)
  MINOR: Upgrade ducktape to 0.7.8 (apache#8879)
  KAFKA-10123; Fix incorrect value for AWAIT_RESET#hasPosition (apache#8841)
  KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest (apache#8883)
  MINOR: clean up unused checkstyle suppressions for Streams (apache#8861)
  MINOR: reuse toConfigObject(Map) to generate Config (apache#8889)
  MINOR: Upgrade jetty to 9.4.27.v20200227 and jersey to 2.31 (apache#8859)
  MINOR: Fix flaky HighAvailabilityTaskAssignorIntegrationTest (apache#8884)
  KAFKA-10147 MockAdminClient#describeConfigs(Collection<ConfigResource>) is unable to handle broker resource (apache#8853)
  KAFKA-10165: Remove Percentiles from e2e metrics (apache#8882)

# Conflicts:
#	core/src/main/scala/kafka/log/Log.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ableegoldman ableegoldman ableegoldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vvcephei @ableegoldman