MINOR: Upgrade jetty to 9.4.30.v20200611#8893
Merged
kkonstantine merged 1 commit intoapache:trunkfrom Jun 29, 2020
Merged
Conversation
Contributor
Author
Contributor
Author
|
The current use in jersey can be found here |
Member
|
retest this please |
Contributor
Author
|
2/3 builds are green, while the other one failed with 3 flaky MM2 tests. |
kkonstantine
added a commit
to confluentinc/rest-utils
that referenced
this pull request
Jun 29, 2020
Aligns versions with AK. See also: apache/kafka#8893 Jetty is currently upgraded to a version higher than what Jersey depends on, because the renaming of Response#closeOutput to Response#completeOutput has been reversed in recent versions.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently commit 492306a updated both jetty to version 9.4.27.v20200227 and jersey to version 2.31
However in the latest versions of jetty, the renaming of the method
Response#closeOutputtoResponse#completeOutputhas been reverted, with the latest version using againResponse#closeOutput.Jersey has not released a recent version in which
Response#closeOutputis called directly. In its latest version 2.31Response#closeOutputwill be called ifResponse#completeOutputthrows aNoSuchMethodErrorexception, which keeps things functional but inefficient.Therefore we can choose to merge this PR early, while waiting for a new version of jersey, or we could wait and update both dependencies together again.
Committer Checklist (excluded from commit message)