Skip to content

MINOR: Upgrade jetty to 9.4.30.v20200611 and jersey to 2.31#184

Merged
Konstantine Karantasis (kkonstantine) merged 2 commits intoconfluentinc:masterfrom
kkonstantine:jersey-jetty-upgrade
Jun 29, 2020
Merged

MINOR: Upgrade jetty to 9.4.30.v20200611 and jersey to 2.31#184
Konstantine Karantasis (kkonstantine) merged 2 commits intoconfluentinc:masterfrom
kkonstantine:jersey-jetty-upgrade

Conversation

@kkonstantine
Copy link
Copy Markdown
Member

Align versions with AK.

@ghost
Copy link
Copy Markdown

Confluent Inc. (@confluentinc) It looks like Konstantine Karantasis (@kkonstantine) just signed our Contributor License Agreement. 👍

Always at your service,

clabot

Copy link
Copy Markdown
Member

@ijuma Ismael Juma (ijuma) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@kkonstantine
Copy link
Copy Markdown
Member Author

We are hitting an issue with an incompatible change in jetty described here:
jetty/jetty.project#4693
This change (the renaming of closeOutput to completeOutput is reverted in more recent versions).
Oldest version that has a fix is: jetty-9.4.28.v20200408 by looking at https://github.com/eclipse/jetty.project/releases
Probably best to upgrade to this version or newer instead of 9.4.27.v20200227

Wdyt Ismael Juma (@ijuma) ?

@ijuma
Copy link
Copy Markdown
Member

Konstantine Karantasis (@kkonstantine) The jersey upgrade was supposed to have fixed that since 9.4.27 is what they actually test it according to the submitter.

@kkonstantine
Copy link
Copy Markdown
Member Author

I see. I didn't check jersey. But we are hitting an issue in SR where the jetty method Response#closeOutput is used directly from jetty.

Comment thread pom.xml Outdated
@kkonstantine Konstantine Karantasis (kkonstantine) changed the title MINOR: Upgrade jetty to 9.4.27.v20200227 and jersey to 2.31 MINOR: Upgrade jetty to 9.4.30.v20200611 and jersey to 2.31 Jun 17, 2020
@kkonstantine
Copy link
Copy Markdown
Member Author

The build is now passing with jetty version 9.4.30.v20200611.

Ismael Juma (@ijuma) if we are good to go here, I'll merge and submit a PR in AK to align the versions there as well.

Copy link
Copy Markdown
Member

@ijuma Ismael Juma (ijuma) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@kkonstantine
Copy link
Copy Markdown
Member Author

The equivalent PR in AK has been merged: apache/kafka#8893
Aligning the versions here too. Thanks Ismael Juma (@ijuma) Ewen Cheslack-Postava (@ewencp)

@kkonstantine Konstantine Karantasis (kkonstantine) merged commit 23ffc8b into confluentinc:master Jun 29, 2020
@kkonstantine Konstantine Karantasis (kkonstantine) deleted the jersey-jetty-upgrade branch June 29, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants