MINOR; Make KafkaAdminClientTest.testDescribeLogDirsPartialFailure and KafkaAdminClientTest.testAlterReplicaLogDirsPartialFailure test more reliable#9091
Merged
hachikuji merged 2 commits intoapache:trunkfrom Sep 10, 2020
Conversation
Member
Author
chia7712
approved these changes
Jul 28, 2020
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
That test is specific for the retries so it doesn't make sense to remove the retries config.
Thanks! I looped this test 100 times, all pass!
…d KafkaAdminClientTest.testAlterReplicaLogDirsPartialFailure test more reliable
dajac
force-pushed
the
minor-fix-flaky-admin-client-tests
branch
from
be543d6 to
cbbc1cd
Compare
Member
Author
|
rebased to fix conflicts. |
3 tasks
3 tasks
3 tasks
Contributor
|
I rebased and tested locally. Merging to trunk. |
abbccdda
pushed a commit
to abbccdda/kafka
that referenced
this pull request
Sep 28, 2020
Fixes flakiness in `KafkaAdminClientTest` as a result of apache#8864. Addresses the following flaky tests: - testAlterReplicaLogDirsPartialFailure - testDescribeLogDirsPartialFailure - testMetadataRetries Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Jason Gustafson <jason@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have seem them failing locally from times to times. It seems that the changes made in #8864 have made them more fragile. I have updated them to be more reliable.
Committer Checklist (excluded from commit message)