MINOR: Fix JSON generation of nested structs with non-matching type/name#9277
Merged
hachikuji merged 2 commits intoapache:trunkfrom Sep 10, 2020
Merged
MINOR: Fix JSON generation of nested structs with non-matching type/name#9277hachikuji merged 2 commits intoapache:trunkfrom
hachikuji merged 2 commits intoapache:trunkfrom
Conversation
Contributor
|
LGTM |
3 tasks
Contributor
Author
|
One flaky failure which is fixed by #9091. Will merge to trunk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema specification allows a struct type name to differ from the field name. This works with the generated
Messageclasses, but not with the generated JSON converter. The problem seems to be that the type name gets replaced with the field name when the struct is registered.Committer Checklist (excluded from commit message)