KAFKA-10435; Fetch protocol changes for KIP-595#9275
Merged
hachikuji merged 3 commits intoapache:trunkfrom Sep 15, 2020
Merged
Conversation
Contributor
Author
|
Note this patch includes #9277. I will rebase once it is merged. |
hachikuji
force-pushed
the
KAFKA-10435
branch
from
d311d9a to
0de6cc5
Compare
rajinisivaram
approved these changes
Sep 14, 2020
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@hachikuji Thanks for the PR. Left a few minor comments/questions, apart from that LGTM.
rajinisivaram
approved these changes
Sep 14, 2020
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@hachikuji Thanks for the PR. Left a few minor comments/questions, apart from that LGTM.
rajinisivaram
approved these changes
Sep 15, 2020
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@hachikuji Thanks for the update, looks good. Left one question because I wasn't sure. Apart from that LGTM
rajinisivaram
approved these changes
Sep 15, 2020
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@hachikuji Thanks for the update, LGTM
ijuma
reviewed
Sep 16, 2020
| // Introduced feature versioning support (KIP-584) | ||
| KAFKA_2_7_IV0 | ||
| KAFKA_2_7_IV0, | ||
| // Bup Fetch protocol for Raft protocol (KIP-595) |
Member
There was a problem hiding this comment.
Maybe you can fix this typo in your next PR.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch bumps the
Fetchprotocol as specified by KIP-595: https://cwiki.apache.org/confluence/display/KAFKA/KIP-595%3A+A+Raft+Protocol+for+the+Metadata+Quorum. The main differences are the following:The most notable change is truncation detection. This patch adds logic in the request handling path to detect truncation, but it does not change the replica fetchers to make use of this capability. We are planning to do this separately.
Committer Checklist (excluded from commit message)