KAFKA-10505: Fix parsing of generation log string.#9312
KAFKA-10505: Fix parsing of generation log string.#9312guozhangwang merged 2 commits intoapache:trunkfrom
Conversation
|
Hello, @mjsax @ableegoldman 2 system tests for streams are fails because of an unexpected string format. Please, take a look at my PR. |
|
@nizhikov @ableegoldman Do we know when this broke? What was the old log line and what is the new one? Triggered system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4181/ |
|
@mjsax These tests are broken with the 7e7bb18 Line logging only generationId - 7e7bb18#diff-30048900127c988a69027b70b0ce4eacL504 New line with the whole Generation object logging - 7e7bb18#diff-30048900127c988a69027b70b0ce4eacR590 |
|
Original system test run was aborted for some reason. Kicked off a new set: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4182/ |
|
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4182/ passed now. I'm going to merge this one. |
|
Thanks for the review and merge! |
|
@guozhangwang I think this needs to be cherrypicked back to 2.6 |
Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, Matthias J. Sax <mjsax@apache.org>, Guozhang Wang <wangguoz@gmail.com>
Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, Matthias J. Sax <mjsax@apache.org>, Guozhang Wang <wangguoz@gmail.com>
|
Yup, cherry-picked to 2.6 as well. |
Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, Matthias J. Sax <mjsax@apache.org>, Guozhang Wang <wangguoz@gmail.com>
Two tests fails with the same reason:
This PR fix the above errors by extracting the correct number from the log string.
Committer Checklist (excluded from commit message)