KAFKA-10402: Upgrade system tests to python3#9196
KAFKA-10402: Upgrade system tests to python3#9196guozhangwang merged 25 commits intoapache:trunkfrom
Conversation
ivandasch
left a comment
There was a problem hiding this comment.
Hi, I have some remarks, that should be resolved.
|
@nizhikov could you rebase your PR on trunk so I can trigger a system test run to verify? |
a0d86e1 to
e82021b
Compare
|
test this please |
|
triggered system test as https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4180/ |
|
Hello, @guozhangwang
|
|
Hello, @guozhangwang 2 tests that fails in this branch fails in the trunk too. Please, take a look. |
|
Hello, @guozhangwang Do you have system tests run results? |
|
Excerpt from the Jenkins test run: The IGNORED tests seems to be mostly |
These two tests are fixed by #9312 AFAIK two others are failing in the trunk too. Is it correct? |
Are they ignored in the trunk? |
|
#9312 has been merged it. Could you rebase this PR so I can re-trigger the system test suite? As for the ignored test cases, they are known issues and we can keep them "ignored" for now. |
41804c2 to
316dc95
Compare
done. |
|
Hello, @guozhangwang Can you, please, share the results of the tests run? |
|
Only one test failed this time, and honestly I'm not sure if it is related to your PR or not, here you go: |
|
Hello, @guozhangwang I ran a failed test locally and it passes. Can you, please, advice me, what is the next step? Do we need a ducktape release for it? |
|
Let me re-trigger the test and if the test passed we can merge it |
|
The test |
|
@guozhangwang Great news! Thanks for the help! |
mimaison
left a comment
There was a problem hiding this comment.
The changes look fine, thanks for driving this important upgrade
|
Hello, @guozhangwang , @mimaison The only thing we need to have perfect merge is ducktape release that contains python3 fixes. |
|
We'll want to use a released version of ducktape to get stable tests. I'm working on getting a ducktape release out. |
|
@edenhill Thanks for the help! Appreciate it |
|
Hello @guozhangwang , @mimaison This PR ready to be merged. |
|
Merged to trunk, kudos to @nizhikov for the contribution! |
For now, Kafka system tests use python2 which is outdated and not supported. This PR upgrades python to the third version. Reviewers: Ivan Daschinskiy, Mickael Maison <mickael.maison@gmail.com>, Magnus Edenhill <magnus@edenhill.se>, Guozhang Wang <wangguoz@gmail.com>
* commit '2804257fe221f37e5098bd': (67 commits) KAFKA-10562: Properly invoke new StateStoreContext init (apache#9388) MINOR: trivial cleanups, javadoc errors, omitted StateStore tests, etc. (apache#8130) KAFKA-10564: only process non-empty task directories when internally cleaning obsolete state stores (apache#9373) KAFKA-9274: fix incorrect default value for `task.timeout.ms` config (apache#9385) KAFKA-10362: When resuming Streams active task with EOS, the checkpoint file is deleted (apache#9247) KAFKA-10028: Implement write path for feature versioning system (KIP-584) (apache#9001) KAFKA-10402: Upgrade system tests to python3 (apache#9196) KAFKA-10186; Abort transaction with pending data with TransactionAbortedException (apache#9280) MINOR: Remove `TargetVoters` from `DescribeQuorum` (apache#9376) Revert "KAFKA-10469: Resolve logger levels hierarchically (apache#9266)" MINOR: Don't publish javadocs for raft module (apache#9336) KAFKA-9929: fix: add missing default implementations (apache#9321) KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop (apache#8910) KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651) (apache#9345) KAFKA-10527; Voters should not reinitialize as leader in same epoch (apache#9348) MINOR: Refactor unit tests around RocksDBConfigSetter (apache#9358) KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter (apache#9099) MINOR: Annotate test BlockingConnectorTest as integration test (apache#9379) MINOR: Fix failing test due to KAFKA-10556 PR (apache#9372) KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale. (apache#9320) ...
For now, Kafka system tests use python2 which is outdated and not supported.
This PR upgrades python to the third version.
Committer Checklist (excluded from commit message)