Skip to content

KAFKA-9274: fix incorrect default value for task.timeout.ms config#9385

Merged
mjsax merged 2 commits intoapache:trunkfrom
mjsax:kafka-9274-kip-572-fix-default
Oct 7, 2020
Merged

KAFKA-9274: fix incorrect default value for task.timeout.ms config#9385
mjsax merged 2 commits intoapache:trunkfrom
mjsax:kafka-9274-kip-572-fix-default

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Oct 6, 2020

Part of KIP-572.

Also add handler method to trigger/reset the timeout on a task.

Call for review @vvcephei

 - also add handler method to trigger/reset the timeout on a task
@mjsax mjsax added the streams label Oct 6, 2020
Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mjsax !

- add missing methods to `StateMachineTask`
Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, too @mjsax

@mjsax mjsax merged commit 65c29a9 into apache:trunk Oct 7, 2020
@mjsax mjsax deleted the kafka-9274-kip-572-fix-default branch October 7, 2020 19:17
javierfreire pushed a commit to javierfreire/kafka that referenced this pull request Oct 8, 2020
…pache#9385)

 - part of KIP-572
 - also add handler method to trigger/reset the timeout on a task

Reviewer: John Roesler <john@confluent.io>
ijuma added a commit to confluentinc/kafka that referenced this pull request Oct 8, 2020
* commit '2804257fe221f37e5098bd': (67 commits)
  KAFKA-10562: Properly invoke new StateStoreContext init (apache#9388)
  MINOR: trivial cleanups, javadoc errors, omitted StateStore tests, etc. (apache#8130)
  KAFKA-10564: only process non-empty task directories when internally cleaning obsolete state stores (apache#9373)
  KAFKA-9274: fix incorrect default value for `task.timeout.ms` config (apache#9385)
  KAFKA-10362: When resuming Streams active task with EOS, the checkpoint file is deleted (apache#9247)
  KAFKA-10028: Implement write path for feature versioning system (KIP-584) (apache#9001)
  KAFKA-10402: Upgrade system tests to python3 (apache#9196)
  KAFKA-10186; Abort transaction with pending data with TransactionAbortedException (apache#9280)
  MINOR: Remove `TargetVoters` from `DescribeQuorum` (apache#9376)
  Revert "KAFKA-10469: Resolve logger levels hierarchically (apache#9266)"
  MINOR: Don't publish javadocs for raft module (apache#9336)
  KAFKA-9929: fix: add missing default implementations (apache#9321)
  KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop (apache#8910)
  KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651) (apache#9345)
  KAFKA-10527; Voters should not reinitialize as leader in same epoch (apache#9348)
  MINOR: Refactor unit tests around RocksDBConfigSetter (apache#9358)
  KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter (apache#9099)
  MINOR: Annotate test BlockingConnectorTest as integration test (apache#9379)
  MINOR: Fix failing test due to KAFKA-10556 PR (apache#9372)
  KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale. (apache#9320)
  ...
cadonna pushed a commit to confluentinc/kafka that referenced this pull request Oct 15, 2020
…pache#9385)

 - part of KIP-572
 - also add handler method to trigger/reset the timeout on a task

Reviewer: John Roesler <john@confluent.io>
@mjsax mjsax added the kip Requires or implements a KIP label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kip Requires or implements a KIP streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants