Skip to content

MINOR: Annotate test BlockingConnectorTest as integration test#9379

Merged
kkonstantine merged 1 commit intoapache:trunkfrom
kkonstantine:annotate-integration-test
Oct 6, 2020
Merged

MINOR: Annotate test BlockingConnectorTest as integration test#9379
kkonstantine merged 1 commit intoapache:trunkfrom
kkonstantine:annotate-integration-test

Conversation

@kkonstantine
Copy link
Copy Markdown
Contributor

@kkonstantine kkonstantine commented Oct 6, 2020

BlockingConnectorTest was incorrectly running as a unit test.
Categorize this test correctly as integration test by adding the appropriate annotation

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks!

@kkonstantine
Copy link
Copy Markdown
Contributor Author

JDK 15 was green. Rest of the failures are not relevant.

@kkonstantine kkonstantine merged commit 28d736b into apache:trunk Oct 6, 2020
kkonstantine added a commit that referenced this pull request Oct 6, 2020
`BlockingConnectorTest` was incorrectly running as a unit test. 
Categorize this test correctly as integration test by adding the appropriate annotation

Reviewer: Randall Hauch <rhauch@gmail.com>
javierfreire pushed a commit to javierfreire/kafka that referenced this pull request Oct 8, 2020
…e#9379)

`BlockingConnectorTest` was incorrectly running as a unit test. 
Categorize this test correctly as integration test by adding the appropriate annotation

Reviewer: Randall Hauch <rhauch@gmail.com>
ijuma added a commit to confluentinc/kafka that referenced this pull request Oct 8, 2020
* commit '2804257fe221f37e5098bd': (67 commits)
  KAFKA-10562: Properly invoke new StateStoreContext init (apache#9388)
  MINOR: trivial cleanups, javadoc errors, omitted StateStore tests, etc. (apache#8130)
  KAFKA-10564: only process non-empty task directories when internally cleaning obsolete state stores (apache#9373)
  KAFKA-9274: fix incorrect default value for `task.timeout.ms` config (apache#9385)
  KAFKA-10362: When resuming Streams active task with EOS, the checkpoint file is deleted (apache#9247)
  KAFKA-10028: Implement write path for feature versioning system (KIP-584) (apache#9001)
  KAFKA-10402: Upgrade system tests to python3 (apache#9196)
  KAFKA-10186; Abort transaction with pending data with TransactionAbortedException (apache#9280)
  MINOR: Remove `TargetVoters` from `DescribeQuorum` (apache#9376)
  Revert "KAFKA-10469: Resolve logger levels hierarchically (apache#9266)"
  MINOR: Don't publish javadocs for raft module (apache#9336)
  KAFKA-9929: fix: add missing default implementations (apache#9321)
  KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop (apache#8910)
  KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651) (apache#9345)
  KAFKA-10527; Voters should not reinitialize as leader in same epoch (apache#9348)
  MINOR: Refactor unit tests around RocksDBConfigSetter (apache#9358)
  KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter (apache#9099)
  MINOR: Annotate test BlockingConnectorTest as integration test (apache#9379)
  MINOR: Fix failing test due to KAFKA-10556 PR (apache#9372)
  KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale. (apache#9320)
  ...
rgo pushed a commit to rgo/kafka that referenced this pull request Oct 20, 2020
…e#9379)

`BlockingConnectorTest` was incorrectly running as a unit test. 
Categorize this test correctly as integration test by adding the appropriate annotation

Reviewer: Randall Hauch <rhauch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants