MINOR: KIP-497 Not start Controller2ChannelManager when we are using zookeeper to notify isr change#9574
Closed
dengziming wants to merge 0 commit intoapache:trunkfrom
Closed
MINOR: KIP-497 Not start Controller2ChannelManager when we are using zookeeper to notify isr change#9574dengziming wants to merge 0 commit intoapache:trunkfrom
dengziming wants to merge 0 commit intoapache:trunkfrom
Conversation
Member
Author
|
@abbccdda @hachikuji ,Hi, PTAL. |
dengziming
force-pushed
the
minor-optimize
branch
2 times, most recently
from
28f78af to
805c11d
Compare
dengziming
force-pushed
the
minor-optimize
branch
2 times, most recently
from
4a83f8d to
98bba65
Compare
Member
Author
mumrah
approved these changes
Dec 4, 2020
Member
mumrah
left a comment
mumrah
left a comment
There was a problem hiding this comment.
@dengziming, thanks for the patch! I think this change looks good. We don't need the AlterIsrManager propagation thread to run unless we are running IBP greater than or equal to 2.7-IV2.
LGTM
dengziming
force-pushed
the
minor-optimize
branch
from
af3d9c9 to
baea94d
Compare
Member
Author
|
Closed this since it has been resolved by #9732 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KafkaServer Start alterIsrChannelManager even when we are using zookeeper to notify isr change.
BrokerToControllerChannelManager will consume some resources when started, so we should optimize them as possible.