KAFKA-10799 AlterIsr utilizes ReplicaManager ISR metrics#9677
Merged
mumrah merged 11 commits intoapache:trunkfrom Dec 3, 2020
Merged
KAFKA-10799 AlterIsr utilizes ReplicaManager ISR metrics#9677mumrah merged 11 commits intoapache:trunkfrom
mumrah merged 11 commits intoapache:trunkfrom
Conversation
This allows us to update the ISR metrics in ReplicaManager without introducing it as a dependency to Partition. Also, this change includes updating these metrics for ISR changes done through AlterIsr
hachikuji
reviewed
Dec 2, 2020
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Looks reasonable. Would it be possible to alter one of the existing test cases to verify that the meters are updated?
hachikuji
reviewed
Dec 2, 2020
mumrah
commented
Dec 2, 2020
hachikuji
reviewed
Dec 3, 2020
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
LGTM except for the one case you called it.
hachikuji
reviewed
Dec 3, 2020
Member
Author
|
Failed tests are known flaky https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9677/8/ |
mumrah
added a commit
that referenced
this pull request
Dec 3, 2020
Add small interface to Partition.scala that allows AlterIsr and ZK code paths to update the ISR metrics managed by ReplicaManager. This opens the door for consolidating even more code between the two ISR update code paths. Cherry-picked from trunk
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Dec 3, 2020
…t-for-generated-requests * apache-github/trunk: MINOR: Fix flaky test shouldQueryOnlyActivePartitionStoresByDefault (apache#9681) KAFKA-10799 AlterIsr utilizes ReplicaManager ISR metrics (apache#9677) MINOR: Fix KTable-KTable foreign-key join example (apache#9683) KAFKA-10473: Add docs on partition size-on-disk, and other log-related metrics (apache#9276) KAFKA-10739; Replace EpochEndOffset with automated protocol (apache#9630) KAFKA-10460: ReplicaListValidator format checking is incomplete (apache#9326) KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response (apache#9382) MINOR: Align the UID inside/outside container (apache#9652) KAFKA-10794 Replica leader election is too slow in the case of too many partitions (apache#9675) KAFKA-10090 Misleading warnings: The configuration was supplied but i… (apache#8826) clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochResponse.java clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java core/src/test/scala/unit/kafka/server/epoch/util/ReplicaFetcherMockBlockingSend.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9100, we missed the inclusion of the high level ISR shrink/expand metrics that are managed by ReplicaManager. This PR adds a small abstraction that allows us to mark these metrics without bringing ReplicaManager in as a dependency of Partition.