KAFKA-10460: ReplicaListValidator format checking is incomplete#9326
Merged
mimaison merged 3 commits intoapache:trunkfrom Dec 3, 2020
Merged
KAFKA-10460: ReplicaListValidator format checking is incomplete#9326mimaison merged 3 commits intoapache:trunkfrom
mimaison merged 3 commits intoapache:trunkfrom
Conversation
viktorsomogyi
requested changes
Sep 29, 2020
Contributor
viktorsomogyi
left a comment
viktorsomogyi
left a comment
There was a problem hiding this comment.
It looks like you have some test failures. Would you please check them?
Contributor
Author
|
@viktorsomogyi, the tests are passing after the last commit. Can you please review it? |
viktorsomogyi
approved these changes
Nov 23, 2020
Contributor
|
@mimaison would you please quickly review this? |
Member
|
@ankit-kumar-25 Thanks for the PR. Can you add a test? |
Contributor
Author
|
Hey @mimaison, Thank you for your input. I have added a couple of test cases to validate this condition. For some reason the |
Member
|
Thanks for the update. The changes look fine. |
Member
|
Travis/Jenkins are having issues. I ran all tests locally and they passed. |
mimaison
approved these changes
Dec 3, 2020
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Dec 3, 2020
…t-for-generated-requests * apache-github/trunk: MINOR: Fix flaky test shouldQueryOnlyActivePartitionStoresByDefault (apache#9681) KAFKA-10799 AlterIsr utilizes ReplicaManager ISR metrics (apache#9677) MINOR: Fix KTable-KTable foreign-key join example (apache#9683) KAFKA-10473: Add docs on partition size-on-disk, and other log-related metrics (apache#9276) KAFKA-10739; Replace EpochEndOffset with automated protocol (apache#9630) KAFKA-10460: ReplicaListValidator format checking is incomplete (apache#9326) KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response (apache#9382) MINOR: Align the UID inside/outside container (apache#9652) KAFKA-10794 Replica leader election is too slow in the case of too many partitions (apache#9675) KAFKA-10090 Misleading warnings: The configuration was supplied but i… (apache#8826) clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochResponse.java clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java core/src/test/scala/unit/kafka/server/epoch/util/ReplicaFetcherMockBlockingSend.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? :: See https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ConfigHandler.scala#L220 . The logic is supposed to accept only two cases:
list of k:v pairs
a single ''
But in practice, since the disjunction's second part only checks that the head is '', the case where a k:v list is headed by a star is also accepted (and then later broker dies at startup, refusing the value).
JIRA: https://issues.apache.org/jira/browse/KAFKA-10460
@viktorsomogyi Can you please review this?