MINOR: Fix flaky test shouldQueryOnlyActivePartitionStoresByDefault#9681
Merged
guozhangwang merged 1 commit intoapache:trunkfrom Dec 3, 2020
Merged
Conversation
Member
Author
|
Call for review: @vvcephei @ableegoldman @guozhangwang |
cadonna
commented
Dec 3, 2020
| final boolean kafkaStreams1IsActive = (keyQueryMetadata.activeHost().port() % 2) == 1; | ||
|
|
||
| // Assert that only active is able to query for a key by default | ||
| assertThat(kafkaStreams1IsActive ? store1.get(key) : store2.get(key), is(notNullValue())); |
Member
Author
There was a problem hiding this comment.
Last time we forgot to move this line into the try-catch-clause.
| } else { | ||
| assertThat(store1.get(key), is(nullValue())); | ||
| assertThat(store2.get(key), is(notNullValue())); | ||
| } |
Member
Author
There was a problem hiding this comment.
I thought this is easier readable.
guozhangwang
approved these changes
Dec 3, 2020
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Dec 3, 2020
…t-for-generated-requests * apache-github/trunk: MINOR: Fix flaky test shouldQueryOnlyActivePartitionStoresByDefault (apache#9681) KAFKA-10799 AlterIsr utilizes ReplicaManager ISR metrics (apache#9677) MINOR: Fix KTable-KTable foreign-key join example (apache#9683) KAFKA-10473: Add docs on partition size-on-disk, and other log-related metrics (apache#9276) KAFKA-10739; Replace EpochEndOffset with automated protocol (apache#9630) KAFKA-10460: ReplicaListValidator format checking is incomplete (apache#9326) KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response (apache#9382) MINOR: Align the UID inside/outside container (apache#9652) KAFKA-10794 Replica leader election is too slow in the case of too many partitions (apache#9675) KAFKA-10090 Misleading warnings: The configuration was supplied but i… (apache#8826) clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochResponse.java clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java core/src/test/scala/unit/kafka/server/epoch/util/ReplicaFetcherMockBlockingSend.scala
3 tasks
guozhangwang
pushed a commit
that referenced
this pull request
Jan 15, 2021
…9681) Reviewers: Guozhang Wang <wangguoz@gmail.com>
Contributor
|
Cherry-picked to 2.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)