Skip to content

MINOR: Align the UID inside/outside container#9652

Merged
chia7712 merged 1 commit intoapache:trunkfrom
chia7712:MINOR-9652
Dec 3, 2020
Merged

MINOR: Align the UID inside/outside container#9652
chia7712 merged 1 commit intoapache:trunkfrom
chia7712:MINOR-9652

Conversation

@chia7712
Copy link
Copy Markdown
Member

The root cause of causing permission issue is that the uid outside container is not 1000 so container (has uid 1000) can't modify the file of /opt/kafka-dev

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712 chia7712 mentioned this pull request Nov 25, 2020
3 tasks
@chia7712
Copy link
Copy Markdown
Member Author

@ijuma @hachikuji please take a look. I'd like to see all green from our QA.

@showuon
Copy link
Copy Markdown
Member

showuon commented Nov 25, 2020

@chia7712 , great to see you have the same thoughts to fix this issue. It's quite annoying to keep breaking the PR build. The change LGTM. Let's see the build results!

Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this! Here are a few potential follow-ups I can think of:

  • Tune the set of tests to address the timeouts
  • Figure out how to surface more convenient test output (logging and such)

Anything else?

@chia7712
Copy link
Copy Markdown
Member Author

chia7712 commented Dec 3, 2020

Tune the set of tests to address the timeouts
Figure out how to surface more convenient test output (logging and such)

The list is LGTM. BTW, #9673 is trying to fix failed connect_distributed_test.py. Please take a look :)

@chia7712 chia7712 merged commit abb8ff6 into apache:trunk Dec 3, 2020
@chia7712 chia7712 changed the title MINOR: Align the uid inside/outside container MINOR: Align the UID inside/outside container Dec 3, 2020
@chia7712
Copy link
Copy Markdown
Member Author

chia7712 commented Dec 3, 2020

Tune the set of tests to address the timeouts
Figure out how to surface more convenient test output (logging and such)

@hachikuji Please ping me on the jira when you create related tickets :)

ijuma added a commit to ijuma/kafka that referenced this pull request Dec 3, 2020
…t-for-generated-requests

* apache-github/trunk:
MINOR: Fix flaky test shouldQueryOnlyActivePartitionStoresByDefault
(apache#9681)
  KAFKA-10799 AlterIsr utilizes ReplicaManager ISR metrics (apache#9677)
  MINOR: Fix KTable-KTable foreign-key join example (apache#9683)
KAFKA-10473: Add docs on partition size-on-disk, and other log-related
metrics (apache#9276)
  KAFKA-10739; Replace EpochEndOffset with automated protocol (apache#9630)
KAFKA-10460: ReplicaListValidator format checking is incomplete
(apache#9326)
KAFKA-10554; Perform follower truncation based on diverging epochs in
Fetch response (apache#9382)
  MINOR: Align the UID inside/outside container (apache#9652)
KAFKA-10794 Replica leader election is too slow in the case of too
many partitions (apache#9675)
KAFKA-10090 Misleading warnings: The configuration was supplied but i…
(apache#8826)

clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochResponse.java
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
core/src/test/scala/unit/kafka/server/epoch/util/ReplicaFetcherMockBlockingSend.scala
@chia7712 chia7712 deleted the MINOR-9652 branch March 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants