KAFKA-10289 fix failed connect_distributed_test.py (ConnectDistribute…#9673
Merged
hachikuji merged 1 commit intoapache:trunkfrom Dec 9, 2020
Merged
KAFKA-10289 fix failed connect_distributed_test.py (ConnectDistribute…#9673hachikuji merged 1 commit intoapache:trunkfrom
hachikuji merged 1 commit intoapache:trunkfrom
Conversation
3 tasks
3 tasks
…dTest.test_bounce)
Member
Author
|
@hachikuji Could you take a look? I have test this patch on my local. It pass. command result command result |
3 tasks
kkonstantine
pushed a commit
that referenced
this pull request
Jan 15, 2021
…edTest.test_bounce) (#9673) In Python 3, `filter` functions return iterators rather than `list` so it can traverse only once. Hence, the following loop will only see "empty" and then validation fails. ```python src_messages = self.source.committed_messages() # return iterator sink_messages = self.sink.flushed_messages()) # return iterator for task in range(num_tasks): # only first task can "see" the result. following tasks see empty result src_seqnos = [msg['seqno'] for msg in src_messages if msg['task'] == task] ``` Reference: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter. Reviewers: Jason Gustafson <jason@confluent.io>
Gerrrr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Mar 21, 2022
…edTest.test_bounce) (apache#9673) In Python 3, `filter` functions return iterators rather than `list` so it can traverse only once. Hence, the following loop will only see "empty" and then validation fails. ```python src_messages = self.source.committed_messages() # return iterator sink_messages = self.sink.flushed_messages()) # return iterator for task in range(num_tasks): # only first task can "see" the result. following tasks see empty result src_seqnos = [msg['seqno'] for msg in src_messages if msg['task'] == task] ``` Reference: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter. Reviewers: Jason Gustafson <jason@confluent.io>
Gerrrr
added a commit
to confluentinc/kafka
that referenced
this pull request
Mar 22, 2022
…edTest.test_bounce) (apache#9673) (#687) In Python 3, `filter` functions return iterators rather than `list` so it can traverse only once. Hence, the following loop will only see "empty" and then validation fails. ```python src_messages = self.source.committed_messages() # return iterator sink_messages = self.sink.flushed_messages()) # return iterator for task in range(num_tasks): # only first task can "see" the result. following tasks see empty result src_seqnos = [msg['seqno'] for msg in src_messages if msg['task'] == task] ``` Reference: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter. Reviewers: Jason Gustafson <jason@confluent.io> Co-authored-by: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: https://issues.apache.org/jira/browse/KAFKA-10289
In Python 3,
filterfunctions return iterators rather thanlistso it can traverse only once. Hence, the following loop only see "empty" and then validation fails.reference: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter
Committer Checklist (excluded from commit message)